-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzz tests for inclusion and consistency proofs #33
Conversation
ce4b930
to
9ffe0eb
Compare
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 88.93% 89.33% +0.40%
==========================================
Files 7 7
Lines 497 497
==========================================
+ Hits 442 444 +2
+ Misses 50 48 -2
Partials 5 5
Continue to review full report at Codecov.
|
What's the motivation behind removing the 1.17 tests? The go.mod file still lists this version as 1.16 compatible. I'm up for bumping this to go1.17 to be consistent with trillian (and soon, trillian-examples: google/trillian-examples#669), but jumping to 1.18 invites using newer language features that may exclude people on older tooling. Not to say we absolutely can't do it, as we don't have an explicit policy, but we've tried to keep support for go versions in the order of a year old thus far. |
It's the fuzz testing support - it's new in go1.18 Agreed we should chat about the trade off. |
We _may_ want to go further than this to support fuzzing (transparency-dev#33), but as an interim go1.17 is sufficiently old that I don't think we'll be excluding anyone by bumping to this.
We _may_ want to go further than this to support fuzzing (#33), but as an interim go1.17 is sufficiently old that I don't think we'll be excluding anyone by bumping to this.
I've just seen #32 and think that this PR with the changes to keep support for 1.17 would make this a super 👍 |
Also fuzz HashAt and InclusionProof against reference implementations Add seed cases to all fuzz tests
@hickford can you take a look at & respond to the open comments on this PR. Once addressed one way or another, I can merge this. |
Fuzz tests for inclusion and consistency proofs