Fuzz test for compact.RangeNodes #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires https://pkg.go.dev/testing#F "added in go1.18", so would need to adjust CI |
AlCutter
approved these changes
Jul 18, 2022
mhutchinson
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
This with the changes @AlCutter has done to put the new features behind a build flag so that we're still compatible with 1.17 looks very tasty to me. Good work, team.
|
I've added a couple of commits for discussion:
@hickford What do you think? |
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 88.93% 88.93%
=======================================
Files 7 7
Lines 497 497
=======================================
Hits 442 442
Misses 50 50
Partials 5 5 Continue to review full report at Codecov.
|
|
@AlCutter LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading https://github.com/transparency-dev/merkle/blob/main/docs/compact_ranges.md I was inspired to write a simple fuzz test for compact.RangeNodes that checks the property "a compact range is the minimal set of perfect nodes that cover these, and only these, leaves"