meta: improve js2ts script #4786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `@ts-ignore` comment on `package.json` imports. - better detect imports of local `.js` files. - do not remove non-JS files from the source.
|
Running this in core no longer crashes but it also doesn't do anything anymore besides adding a |
Merged
github-actions bot
added a commit
that referenced
this pull request
Nov 24, 2023
| Package | Version | Package | Version | | ---------------------- | ------- | ---------------------- | ------- | | @uppy/companion-client | 3.6.1 | @uppy/store-default | 3.1.0 | | @uppy/locales | 3.5.0 | uppy | 3.20.0 | - meta: uppy CDN: Export UIPlugin and BasePlugin (Artur Paikin / #4774) - @uppy/locales: Add missing translations to de_DE (Leonhard Melzer / #4800) - @uppy/store-default: refactor to typescript (Antoine du Hamel / #4785) - meta: improve js2ts script (Antoine du Hamel / #4786) - @uppy/companion-client: fix log type error (Mikael Finstad / #4766) - @uppy/companion-client: revert breaking change (Antoine du Hamel / #4801) - @uppy/locales: use TypeScript for source files (Antoine du Hamel / #4779) - meta: migrate AWS SDK v2 to v3 in `bin/uploadcdn` (Trivikram Kamat / #4776)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ts-ignorecomment onpackage.jsonimports..jsfiles.