Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/locales: use TypeScript for source files #4779

Merged
merged 7 commits into from
Nov 20, 2023
Merged

@uppy/locales: use TypeScript for source files #4779

merged 7 commits into from
Nov 20, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 6, 2023

No description provided.

@aduh95
Copy link
Contributor Author

aduh95 commented Nov 9, 2023 •
edited
Loading

@Murderlon I think the CI failures are making a good point regarding why using a generic for Locale is a good idea :)

packages/@uppy/locales/src/vi_VN.ts:152:5 - error TS2322: Type '{ '0': string; '1': string; '2': string; }' is not assignable to type 'string | Record<0 | 1, string>'.
  Object literal may only specify known properties, and ''2'' does not exist in type 'Record<0 | 1, string>'.

152     '2': 'Chọn ít nhất %{smart_count} tập tin',
        ~~~

@aduh95 aduh95 merged commit c60ece4 into transloadit:main Nov 20, 2023
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
Merged
github-actions bot added a commit that referenced this pull request Nov 24, 2023
@github-actions
Release: uppy@3.20.0 (#4804)
de1b4ab 
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/companion-client |   3.6.1 | @uppy/store-default    |   3.1.0 |
| @uppy/locales          |   3.5.0 | uppy                   |  3.20.0 |

- meta: uppy CDN: Export UIPlugin and BasePlugin (Artur Paikin / #4774)
- @uppy/locales: Add missing translations to de_DE (Leonhard Melzer / #4800)
- @uppy/store-default: refactor to typescript (Antoine du Hamel / #4785)
- meta: improve js2ts script (Antoine du Hamel / #4786)
- @uppy/companion-client: fix log type error (Mikael Finstad / #4766)
- @uppy/companion-client: revert breaking change (Antoine du Hamel / #4801)
- @uppy/locales: use TypeScript for source files (Antoine du Hamel / #4779)
- meta: migrate AWS SDK v2 to v3 in `bin/uploadcdn` (Trivikram Kamat / #4776)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Murderlon Murderlon Murderlon approved these changes

Assignees
No one assigned
Labels
pending end-to-end tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduh95 @Murderlon