@uppy/transloadit: close assembly if upload is cancelled

[aduh95]

Fixes: #3156

[Murderlon]

LGTM but sounds like a good use case for a test?

[aduh95]

good use case for a test?

You're right it is 🥲

[Murderlon]

Final touches:

1. We should add this command:

Cypress.Commands.add('getBySel', (selector, ...args) => {
  return cy.get(`[data-test=${selector}]`, ...args)
})

2. Also add data-cy for upload/retry/pause buttons
3. Go through the tests and replace all button queries with new command / query

[aduh95]

1. We should add this command:

I disagree, I find the cy.get([data-cy=…]) much more readable than cy.getBySel(…).

• Also add data-cy for upload/retry/pause buttons
• Go through the tests and replace all button queries with new command / query

I think it's out of the scope of this PR, and it shouldn't hold back the release.

[Murderlon]

I think it's out of the scope of this PR, and it shouldn't hold back the release.

Well it has to be done sooner or later in my opinion. We can walk into it again in another PR for which it's also out of scope, or we remember to follow up on it. Either way is fine.

[aduh95]

2. Also add data-cy for upload/retry/pause buttons

It looks like the upload button already has a specific CSS class associated with it, is there really useful to add data-cy on top of it?
AFAICS, we have no tests that target retry or pause buttons, let's add some.