@uppy/robodog: fix CDN bundle #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It used to be a
But yeah, how did it work a version before then, hmm 🤔 |
arturi
reviewed
Mar 21, 2022
| @@ -1 +1,2 @@ | |||
| module.exports = require('./bundle-legacy.js') | |||
| // eslint-disable-next-line no-multi-assign | |||
| globalThis.Robodog = module.exports = require('./bundle-legacy.js') | |||
There was a problem hiding this comment.
Do we have to use legacy / heavier bundle?
There was a problem hiding this comment.
Robodog bundle has never been cleansed from polyfills, that would be a breaking change.
arturi
reviewed
Mar 21, 2022
| @@ -1 +1,2 @@ | |||
| module.exports = require('./bundle-legacy.js') | |||
| // eslint-disable-next-line no-multi-assign | |||
| globalThis.Robodog = module.exports = require('./bundle-legacy.js') | |||
There was a problem hiding this comment.
Do we have to use legacy / heavier bundle?
arturi
approved these changes
Mar 21, 2022
Merged
github-actions bot
added a commit
that referenced
this pull request
Mar 24, 2022
| Package | Version | Package | Version | | ----------------- | ------- | ----------------- | ------- | | @uppy/companion | 3.5.0 | @uppy/webcam | 2.1.0 | | @uppy/status-bar | 2.1.3 | @uppy/robodog | 2.5.0 | | @uppy/transloadit | 2.1.2 | uppy | 2.9.0 | | @uppy/tus | 2.2.1 | | | - @uppy/transloadit: close assembly if upload is cancelled (Antoine du Hamel / #3591) - @uppy/companion: Companion server upload events (Mikael Finstad / #3544) - @uppy/tus: fix double requests sent when rate limiting (Antoine du Hamel / #3595) - website: fix linter error on blog post (Antoine du Hamel / #3596) - @uppy/companion: fix `yarn test` command (Antoine du Hamel / #3590) - @uppy/webcam: Mime types in webcam options type (Sobakin Sviatoslav / #3593) - website: Some polish and a better (?) intro for the recent update post (AJvanLoon / #3588) - @uppy/companion: Allow setting no ACL (Mikael Finstad / #3577) - @uppy/companion: Small companion code and doc changes (Mikael Finstad / #3586) - @uppy/robodog: fix CDN bundle (Antoine du Hamel / #3587) - website: Fix broken link (YukeshShr / #3581)
HeavenFox
pushed a commit
to docsend/uppy
that referenced
this pull request
Jun 27, 2023
| Package | Version | Package | Version | | ----------------- | ------- | ----------------- | ------- | | @uppy/companion | 3.5.0 | @uppy/webcam | 2.1.0 | | @uppy/status-bar | 2.1.3 | @uppy/robodog | 2.5.0 | | @uppy/transloadit | 2.1.2 | uppy | 2.9.0 | | @uppy/tus | 2.2.1 | | | - @uppy/transloadit: close assembly if upload is cancelled (Antoine du Hamel / transloadit#3591) - @uppy/companion: Companion server upload events (Mikael Finstad / transloadit#3544) - @uppy/tus: fix double requests sent when rate limiting (Antoine du Hamel / transloadit#3595) - website: fix linter error on blog post (Antoine du Hamel / transloadit#3596) - @uppy/companion: fix `yarn test` command (Antoine du Hamel / transloadit#3590) - @uppy/webcam: Mime types in webcam options type (Sobakin Sviatoslav / transloadit#3593) - website: Some polish and a better (?) intro for the recent update post (AJvanLoon / transloadit#3588) - @uppy/companion: Allow setting no ACL (Mikael Finstad / transloadit#3577) - @uppy/companion: Small companion code and doc changes (Mikael Finstad / transloadit#3586) - @uppy/robodog: fix CDN bundle (Antoine du Hamel / transloadit#3587) - website: Fix broken link (YukeshShr / transloadit#3581)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's still unclear to how it was working before that – I couldn't find where the global variable used to be assigned and when that was removed. Anyway, the fix is quite straight-forward, we should release a new version with the fix soon.
Fixes: #3582