Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Log warning instead of an error when trigger is not found #2144

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Dashboard: Log warning instead of an error when trigger is not found #2144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8581da
Log warning instead of an error when trigger is not found
arturi Mar 18, 2020
68e7cdb
Only issue warning if opts.trigger is not set
arturi Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/@uppy/dashboard/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,13 +609,13 @@ module.exports = class Dashboard extends Plugin {

initEvents () {
// Modal open button
const showModalTrigger = findAllDOMElements(this.opts.trigger)
if (!this.opts.inline && showModalTrigger) {
showModalTrigger.forEach(trigger => trigger.addEventListener('click', this.openModal))
}

if (!this.opts.inline && !showModalTrigger) {
this.uppy.log('Dashboard modal trigger not found. Make sure `trigger` is set in Dashboard options unless you are planning to call openModal() method yourself', 'error')
if (this.opts.trigger && !this.opts.inline) {
const showModalTrigger = findAllDOMElements(this.opts.trigger)
if (showModalTrigger) {
showModalTrigger.forEach(trigger => trigger.addEventListener('click', this.openModal))
} else {
this.uppy.log('Dashboard modal trigger not found. Make sure `trigger` is set in Dashboard options, unless you are planning to call `dashboard.openModal()` method yourself', 'warning')
}
}

this.startListeningToResize()
Expand Down