Dashboard: Log warning instead of an error when trigger is not found

[arturi]

From a support ticket:

How to get rid of this JS error:
Dashboard modal trigger not found. Make sure trigger is set in Dashboard options unless you are planning to call openModal() method yourself

Of course it should have been a warning all along, but maybe we shouldn’t display it at all, ie when trigger not specified = you intend to call openModal yourself? More noise vs confusion when someone can’t figure out why the Dashboard modal won’t appear 🤔

[goto-bus-stop]

Turned into an error here: #1217

I think the idea for this was to log the error if you did specify a trigger with a CSS selector, but no elements matched it. But the condition doesn't actually check that a trigger selector was set.

[arturi]

Right! 🙏 That thought also crossed my mind. Will update the condition instead.

[arturi]

Trouble is, we have trigger: '#uppy-select-files' as the default :(

Will update the condition and leave the default be, but change to null in 2.0?

[goto-bus-stop]

🤯 that's very silly! At least, now that we have these modal APIs and react components, it is 😛

Maybe we should do that in 2.0 then and do this for now

[arturi]

Well yeah, I think my reasoning was to allow .use(Dashboard) without any config at all — it just picks up a button/input with the correct id on the page by default. I think I’ve seen it done like this somewhere — less boilerplate for the user, but yeah, probably more confusing in the long run.

[goto-bus-stop]

yes, sorry, it likely made sense at an earlier stage. Now that we have all these different ways of using the Dashboard it becomes a bit complicated 😅