Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modifications for standalone - hit selection windows #128

Closed
wants to merge 149 commits into from

Conversation

leonardogiannini
Copy link

some corrections to the standalone code used for deriving the hit selection windows

CeliaFernandez and others added 30 commits February 15, 2023 13:04
This reverts commit d43fe42f7f0e09d5e90b0c44f7777338cb8f495b.
Co-authored-by: Marino Missiroli <m.missiroli@cern.ch>
Co-authored-by: Marino Missiroli <m.missiroli@cern.ch>
Co-authored-by: Marino Missiroli <m.missiroli@cern.ch>
Co-authored-by: Marino Missiroli <m.missiroli@cern.ch>
francescobrivio and others added 20 commits June 13, 2023 22:40
Fix UBSAN warning in DataFormats/L1TParticleFlow
remove tracking efficiency and fake rate w.r.t. offline plots from list of ME to be outputed by LS
…latedTracks

Filter tracks extrapolated to the muon system
…_dmb_data_corruption

CSC Unpacker fix for handling of rare CSC data corruption
…orMiniAOD

Heavy ions: Added flow modulated CS jets for miniAOD data
…2023v1p2p0

Update of L1T pp menu in TSG GTs to `L1Menu_Collisions2023_v1_2_0_xml`
Change EMTF Primitive Conversion LUT Assignment for MC
Backport RNTuple NanoAOD output module from ROOT6 branch
…napshot

Add new L1T menu to relval/ideal/2024/run4 GTs and re-snapshot data GTS
…3_MC_GTs

Add preliminary GTs for 2023 MC
Definition of a new DQM Offline sequence to be run on Express Stream
Phase2-hgx341A One step to resolve cassette shift issue for V18 where the shift will move the passive elements as well
@slava77
Copy link

slava77 commented Jul 8, 2023

@leonardogiannini
are you still working on this or is it worth to integrate to master/cmssw?

@leonardogiannini
Copy link
Author

leonardogiannini commented Jul 10, 2023

Maybe forcing the push to the old branch was not a good idea!
Anyway, these are all the changes that we need e10bc03

@slava77
Copy link

slava77 commented Jul 10, 2023

Maybe forcing the push to the old branch was not a good idea! Anyway, these are all the changes that we need e10bc03

it looks like you merged master or smth instead of rebasing the existing branch
check http://cms-sw.github.io/tutorial-resolve-conflicts.html

@leonardogiannini
Copy link
Author

I had to move to a more recent release. trackreco/master is also behind master and I can't sync it

@slava77
Copy link

slava77 commented Jul 10, 2023

I had to move to a more recent release. trackreco/master is also behind master and I can't sync it

I've updated trackreco/master now, but the extra commits are still here; perhaps try to force-push once more?

@slava77
Copy link

slava77 commented Jul 10, 2023

a simple comparison https://github.com/trackreco/cmssw/compare/master...leonardogiannini:cmssw:windows-fix?expand=1 doesn't show any extra commits.
I'm not sure if doing a resync after the update triggered the current state here.

It may be easier to open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.