Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tensorflow to 2.11 #8533

Closed
wants to merge 1 commit into from
Closed

Conversation

iarspider
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_2_X/master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d99c19/32887/summary.html
COMMIT: 944d8bb
CMSSW: CMSSW_13_2_X_2023-05-30-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8533/32887/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-45b239628ec2ac864b5e7c7c452f9135/include/eigen3/Eigen/src/Core/util/IntegralConstant.h(187): warning #1835-D: attribute "__host__" does not apply here

Remark: The warnings can be suppressed with "-diag-suppress "

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-30-2300/src/HeterogeneousCore/CUDATest/plugins/TestPortableAnalyzer.cc: In member function 'virtual void TestPortableAnalyzer::analyze(const edm::Event&, const edm::EventSetup&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-30-2300/src/HeterogeneousCore/CUDATest/plugins/TestPortableAnalyzer.cc:74:98: error: 'all' is not a member of 'Eigen'
   74 |         << "  m    @ " << view.metadata().addressOf_m() << " = { ... {" << view[1].m()(1, Eigen::all) << " } ... } \n";
      |                                                                                                  ^~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-30-2300/src/HeterogeneousCore/CUDATest/plugins/TestPortableAnalyzer.cc:74:98: note: suggested alternatives:
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc11/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-45b239628ec2ac864b5e7c7c452f9135/include/eigen3/Eigen/Core:19,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_2_X_2023-05-30-2300/src/DataFormats/PortableTestObjects/interface/TestSoA.h:4,


@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#41873

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d99c19/32986/summary.html
COMMIT: 944d8bb
CMSSW: CMSSW_13_2_X_2023-06-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8533/32986/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d99c19/32986/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d99c19/32986/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test import-downhill had ERRORS
---> test testDownhill had ERRORS
---> test testhep_ml had ERRORS
---> test testTheano had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially removed 40 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3219909
  • DQMHistoTests: Total failures: 106
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219781
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2023

Pull request #8533 was updated.

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2023

Pull request #8533 was updated.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d99c19/33046/summary.html
COMMIT: ff1df20
CMSSW: CMSSW_13_2_X_2023-06-07-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8533/33046/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d99c19/33046/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d99c19/33046/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test import-downhill had ERRORS
---> test import-hep_ml had ERRORS
---> test testDownhill had ERRORS
---> test testhep_ml had ERRORS
and more ...

Comparison Summary

There are some workflows for which there are errors in the baseline:
10804.31 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 61 lines from the logs
  • Reco comparison results: 608 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3219909
  • DQMHistoTests: Total failures: 720
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219167
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor

@iarspider , I think you also need to drop the unit tests from cmssw which are using these dropped externals

@iarspider
Copy link
Contributor Author

please test with cms-sw/cmssw#41950

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d99c19/33138/summary.html
COMMIT: ff1df20
CMSSW: CMSSW_13_2_X_2023-06-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8533/33138/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 55 lines from the logs
  • Reco comparison results: 225 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196062
  • DQMHistoTests: Total failures: 4804
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3191236
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild added a commit to cms-sw/cmssw that referenced this pull request Jun 15, 2023
@cmsbuild
Copy link
Contributor

Pull request #8533 was updated.

@cmsbuild
Copy link
Contributor

Pull request #8533 was updated.

@iarspider iarspider changed the title Update tensorflow to 2.11 Update tensorflow to 2.12 Jun 23, 2023
@iarspider iarspider changed the title Update tensorflow to 2.12 Update tensorflow to 2.11 Jun 23, 2023
@iarspider iarspider closed this Jun 23, 2023
@smuzaffar smuzaffar deleted the tf-1.12-try2 branch July 24, 2023 14:45
Glitchmin pushed a commit to CTPPS/cmssw that referenced this pull request Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants