Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMSSW changes for Eigen API changes #41873

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

iarspider
Copy link
Contributor

PR description:

Companion PR to cms-sw/cmsdist#8533

PR validation:

Bot tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41873/35782

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41873/35783

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2023

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaTest (heterogeneous)
  • HeterogeneousCore/CUDATest (heterogeneous)

@cmsbuild, @makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

smuzaffar commented Jun 5, 2023

@iarspider , isn't it duplicate of #40645 ?

@iarspider
Copy link
Contributor Author

Somewhat - the method in question was moved once again since that PR.

@smuzaffar
Copy link
Contributor

#40645 should have worked as there are no git conflicts in change in #40645 and current state of cmssw master branch. Anyway, I am closing #40645 in favor of this PR

@fwyzard
Copy link
Contributor

fwyzard commented Jun 6, 2023

+heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a15694/33011/summary.html
COMMIT: 431cc20
CMSSW: CMSSW_13_2_X_2023-06-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41873/33011/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3219909
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219878
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants