Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete doesn't trigger recomputation #27

Closed
Tracked by #316
boris-petrov opened this issue Jun 5, 2020 · 3 comments · Fixed by #30
Closed
Tracked by #316

delete doesn't trigger recomputation #27

boris-petrov opened this issue Jun 5, 2020 · 3 comments · Fixed by #30

Comments

@boris-petrov
Copy link

Reproduction.

Clicking the button sets a tracked object's property to something and clicking it a second time does a delete. That should hide some text that is shown and should log undefined. Neither happens. I think this is a bug.

@lifeart
Copy link
Contributor

lifeart commented Jul 28, 2020

@boris-petrov
Copy link
Author

boris-petrov commented Jul 2, 2021

@chriskrycho - now that I think about this, why did you mark this issue as closed? I keep looking at that PR and I see nothing related to it. You can see the two unmerged PRs - they add a deleteProperty handler to the Proxy - and I believe that's the only way to fix this issue.

@chriskrycho chriskrycho reopened this Jul 2, 2021
@chriskrycho
Copy link
Collaborator

Just typo'd which issue it was supposed to resolve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants