bugfix: tracked-tools#27-trigger-recomputation-on-delete

lifeart · Jul 29, 2020 · e264996 · e264996
1 parent 57290b6
commit e264996
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/addon/-private/object.js b/addon/-private/object.js
@@ -50,6 +50,15 @@ const proxyHandler = {
     return true;
   },
 
+  deleteProperty(target, prop) {
+    if (prop in target) {
+      delete target[prop];
+      dirtyKey(target, prop);
+      dirtyKey(target, COLLECTION);
+    }
+    return true;
+  },
+
   getPrototypeOf() {
     return TrackedObject.prototype;
   },

diff --git a/tests/unit/object-test.js b/tests/unit/object-test.js
@@ -148,4 +148,19 @@ module('TrackedObject', function (hooks) {
       }
     }
   );
+
+  reactivityTest(
+    'delete works',
+    class extends Component {
+      obj = new TrackedObject({foo: 1});
+
+      get value() {
+        return this.obj.foo;
+      }
+
+      update() {
+        delete this.obj.foo;
+      }
+    }
+  );
 });