Update Readiness Endpoint In test.guide Helm Chart #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
MartinGroscheTT
changed the title
ErikRehmTT
reviewed
Dec 5, 2024
Comment on lines
64
to
68
| if curl -s http://localhost:{{ .Values.service.targetPort }}{{ .Values.service.readinessPath | default "/api/health/ready" }}; then | ||
| exit 0 | ||
| elif curl -s http://localhost:{{ .Values.service.targetPort }}/api/health/live; then | ||
| exit 0 | ||
| else |
There was a problem hiding this comment.
this is a more complex solution than I expected. In this implementation it doesn't make much sense, as it would be enough to just check .../live for the same result.
If we want to do a more complex check if test.guide is in maintenance mode, we would need to check for http code 503 and a set Retry-After Header
- KISS readinessProbe
ErikRehmTT
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #41