Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readiness endpoint in test.guide helm chart #41

Closed
1 task done
ErikRehmTT opened this issue Nov 26, 2024 · 0 comments · Fixed by #43
Closed
1 task done

Update readiness endpoint in test.guide helm chart #41

ErikRehmTT opened this issue Nov 26, 2024 · 0 comments · Fixed by #43
Assignees
@MartinGroscheTT
Labels
enhancement New feature or request

Comments

@ErikRehmTT
Copy link
Member

ErikRehmTT commented Nov 26, 2024 •
edited
Loading

Description

As developer I want to make sure, that test.guide stays available, when the maintenance mode is activated. The currently used endpoint makes test.guide unready, which causes the load balancer to not route traffic there. Basically correct, but without reaching the instance, the maintenance mode can't be disabled.

Acceptance Criteria

  • test.guide readiness probe tests against the /api/health/live endpoint instead of the /api/health/ready endpoint
@ErikRehmTT ErikRehmTT added the enhancement New feature or request label Nov 26, 2024
@MartinGroscheTT MartinGroscheTT self-assigned this Dec 5, 2024
MartinGroscheTT added a commit that referenced this issue Dec 5, 2024
@MartinGroscheTT
Set readinessProbe for maintenance mode (#41)
a4291dd
@github-actions github-actions bot mentioned this issue Dec 5, 2024
Merged
MartinGroscheTT added a commit that referenced this issue Dec 5, 2024
@MartinGroscheTT
Add review notes (#41)
fe59e04 
- KISS readinessProbe
MartinGroscheTT added a commit that referenced this issue Dec 5, 2024
@MartinGroscheTT
Update chart version (#41)
194e361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinGroscheTT MartinGroscheTT

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Readiness Endpoint In test.guide Helm Chart tracetronic/helm-charts
2 participants
@MartinGroscheTT @ErikRehmTT