Fix pycodestyle E741 errors (#663) #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, in this case, 'l's) and remove ignore of this error in tox.ini
…, in this case, 'l's) and remove ignore of this error in tox.ini
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
- Coverage 93.86% 90.64% -3.23%
==========================================
Files 11 11
Lines 2364 2362 -2
Branches 0 395 +395
==========================================
- Hits 2219 2141 -78
Misses 145 145
- Partials 0 76 +76
Continue to review full report at Codecov.
|
asottile
approved these changes
Nov 9, 2017
tox/result.py
Outdated
| @@ -63,8 +63,8 @@ def set_python_info(self, pythonexecutable): | |||
| version=version) | |||
|
|
|||
| def get_commandlog(self, name): | |||
| l = self.dict.setdefault(name, []) | |||
| return CommandLog(self, l) | |||
| list = self.dict.setdefault(name, []) | |||
There was a problem hiding this comment.
list shadows the builtin list function, I'd pick a different name here
asottile
approved these changes
Nov 9, 2017
gaborbernat
approved these changes
Nov 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pycodestyle E741 errors and re-introduce testing for this in tox. In all these cases, it was
land it represented alist. This is not a good name, so I tried to get something more descriptive. In one case, it was passed to a constructor which hadlistas an argument, so I decided to stick with that.This fixes #663.