Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

followup to #662 - Fix E741 (flake8) #663

Closed
asottile opened this issue Oct 26, 2017 · 3 comments · Fixed by #671
Closed

followup to #662 - Fix E741 (flake8) #663

asottile opened this issue Oct 26, 2017 · 3 comments · Fixed by #671
Labels
level:easy rought estimate that this might be quite easy to implement type:internal should have no impact on the user (refactoring, infrastructure, tools, etc.)

Comments

@asottile
Copy link
Contributor

I've temporarily turned this off in #662 such that we can get our build back to green.

We should go through and fix E741 (ambiguous variable name) -- the variable name in question appears to be l (and I agree, I have no idea what it means!)
@asottile asottile added level:easy rought estimate that this might be quite easy to implement type:internal should have no impact on the user (refactoring, infrastructure, tools, etc.) labels Oct 26, 2017
@obestwalter
Copy link
Member

ah, that's new and I guess it is there because l and 1 can be confused if you use a bad font or something.

@cryvate
Copy link

cryvate commented Nov 8, 2017

I am happy to have a look at this if no-one is working on it yet?

@asottile
Copy link
Contributor Author

asottile commented Nov 8, 2017

Go for it!

@cryvate cryvate mentioned this issue Nov 8, 2017
Merged
gaborbernat pushed a commit that referenced this issue Nov 11, 2017
@cryvate @gaborbernat
Fix pycodestyle E741 errors (#663) (#671)
d70b4b7 
* Fix pycodestyle (formerly pep8) errors E741 (ambiguous variable names, in this case, 'l's) and remove ignore of this error in tox.ini
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
level:easy rought estimate that this might be quite easy to implement type:internal should have no impact on the user (refactoring, infrastructure, tools, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pycodestyle E741 errors (#663) cryvate/tox
3 participants
@obestwalter @asottile @cryvate