-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Register {temp_dir}
as a valid substitution
#1609
Merged
gaborbernat
merged 2 commits into
tox-dev:master
from
webknjaz:bugfixes/temp_dir-substitution
Jun 29, 2020
Merged
🐛 Register {temp_dir}
as a valid substitution
#1609
gaborbernat
merged 2 commits into
tox-dev:master
from
webknjaz:bugfixes/temp_dir-substitution
Jun 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change recovers a missing `temp_dir` substitution. The docs for it were added in tox-dev#1032 but it never actually worked. Fixes tox-dev#1608
webknjaz
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
June 28, 2020 23:22
webknjaz
added a commit
to ansible/ansible-lint
that referenced
this pull request
Jun 28, 2020
webknjaz
added a commit
to ansible/ansible-lint
that referenced
this pull request
Jun 28, 2020
gaborbernat
reviewed
Jun 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
@gaborbernat thanks! mind publishing a bugfix release? |
webknjaz
added a commit
to ansible/ansible-lint
that referenced
this pull request
Jun 29, 2020
This change enxures that `{temp_dir}` substitution actually works. Refs: * tox-dev/tox#1608 * tox-dev/tox#1609 * tox-dev/tox#1610
ssbarnea
pushed a commit
to ssbarnea/tox
that referenced
this pull request
Apr 19, 2021
webknjaz
added a commit
to webknjaz/ansible-navigator
that referenced
this pull request
Aug 21, 2021
webknjaz
added a commit
to webknjaz/ansible-navigator
that referenced
this pull request
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change recovers a missing
temp_dir
substitution.The docs for it were added in #1032 but it never actually worked.
Fixes #1608
Contribution checklist:
in message body
<issue number>.<type>.rst
for example (588.bugfix.rst)<type>
is must be one ofbugfix
,feature
,deprecation
,breaking
,doc
,misc
<your username>
"superuser
."CONTRIBUTORS
(preserving alphabetical order)