Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{temp_dir} does not work #1608

Closed
webknjaz opened this issue Jun 28, 2020 · 0 comments · Fixed by #1609
Closed

{temp_dir} does not work #1608

webknjaz opened this issue Jun 28, 2020 · 0 comments · Fixed by #1609
Labels
bug:normal affects many people or has quite an impact pr-merged

Comments

@webknjaz
Copy link
Contributor 

Traceback (most recent call last):
  File "~/.pyenv/versions/3.8.0/lib/python3.8/runpy.py", line 192, in _
run_module_as_main
    return _run_code(code, main_globals, None,
  File "~/.pyenv/versions/3.8.0/lib/python3.8/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/__main__.py", line 4, in <module>
    tox.cmdline()
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/session/__init__.py", line 44, in cmdline
    main(args)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/session/__init__.py", line 64, in main
    config = load_config(args)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/session/__init__.py", line 80, in load_config
    config = parseconfig(args)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 274, in parseconfig
    ParseIni(config, config_file, content)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1193, in __init__
    raise tox.exception.ConfigError(
tox.exception.ConfigError: ConfigError: docs failed with ConfigError: substitution key 'temp_dir' not found at Traceback (most recent call last):
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1169, in run
    results[name] = cur_self.make_envconfig(name, section, subs, config)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1317, in make_envconfig
    res = meth(env_attr.name, env_attr.default, replace=replace)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1586, in getargvlist
    return _ArgvlistReader.getargvlist(self, s, replace=replace)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1796, in getargvlist
    commands.append(cls.processcommand(reader, current_command, replace))
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1832, in processcommand
    new_word = reader._replace(word)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1643, in _replace
    replaced = Replacer(self, crossonly=crossonly).do_replace(value)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1679, in do_replace
    expanded = substitute_once(value)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1677, in substitute_once
    return self.RE_ITEM_REF.sub(self._replace_match, x)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1724, in _replace_match
    return self._replace_substitution(match)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1759, in _replace_substitution
    val = self._substitute_from_other_section(sub_key)
  File ".../.tox/.tox/lib/python3.8/site-packages/tox/config/__init__.py", line 1753, in _substitute_from_other_section
    raise tox.exception.ConfigError("substitution key {!r} not found".format(key))
tox.exception.ConfigError: ConfigError: substitution key 'temp_dir' not found

Ref: https://github.com/tox-dev/tox/pull/1032/files#r446709505
@webknjaz webknjaz added the bug:normal affects many people or has quite an impact label Jun 28, 2020
webknjaz added a commit to webknjaz/tox that referenced this issue Jun 28, 2020
@webknjaz
🐛 Register {temp_dir} as a valid substitution
8035da4 
This change recovers a missing `temp_dir` substitution.
The docs for it were added in tox-dev#1032 but it never actually worked.

Fixes tox-dev#1608
@webknjaz webknjaz mentioned this issue Jun 28, 2020
Merged
6 tasks
@helpr helpr bot added the pr-available label Jun 28, 2020
webknjaz added a commit to ansible/ansible-lint that referenced this issue Jun 28, 2020
@webknjaz
🚑 Hotfix tox's {temp_dir} substitution bug
ce29199 
Refs:
* tox-dev/tox#1608
* tox-dev/tox#1609
webknjaz added a commit to ansible/ansible-lint that referenced this issue Jun 28, 2020
@webknjaz
🚑 Hotfix tox's {temp_dir} substitution bug
a06b0fb 
Refs:
* tox-dev/tox#1608
* tox-dev/tox#1609
@helpr helpr bot added pr-merged and removed pr-available labels Jun 29, 2020
webknjaz added a commit to ansible/ansible-lint that referenced this issue Jun 29, 2020
@webknjaz
Set min required tox to 3.16.1
a459115 
This change enxures that `{temp_dir}` substitution actually works.

Refs:
* tox-dev/tox#1608
* tox-dev/tox#1609
* tox-dev/tox#1610
@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug:normal affects many people or has quite an impact pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Register {temp_dir} as a valid substitution webknjaz/tox
1 participant
@webknjaz