On Windows LOCALAPPDATA is missing in os.environ #3429
Comments
|
The variable is not listed on https://learn.microsoft.com/en-us/windows/deployment/usmt/usmt-recognized-environment-variables. The referenced While I find some mentions of In #3151 @gaborbernat made the case that we happily include env variables that are required by the standard lib, but not app specific ones. |
|
See the following for example. There are multiple references to this environment variable. That is with a quick Google search. https://learn.microsoft.com/en-us/windows/win32/msi/installation-contexthttps://learn.microsoft.com/en-us/windows/win32/shell/knownfolderid#FOLDERID_UserProgramFilesWhile that package may not be actively maintained, it is a dependency of many other packages. And that is only one example. I can imagine many in-house apps that run on Windows rely on this environment variable as well.On Oct 29, 2024, at 12:46 AM, Jürgen Gmach ***@***.***> wrote:
The variable is not listed on https://learn.microsoft.com/en-us/windows/deployment/usmt/usmt-recognized-environment-variables.
The referenced python-certifi-win32 is unmaintained, see https://pypi.org/project/python-certifi-win32/.
While I find some mentions of LOCALAPPDATA on stackoverflow, I do not recognize a clear pattern why this should be included.
In #3151 @gaborbernat made the case that we happily include env variables that are required by the standard lib, but not app specific ones.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
My barrier of entry did not change. If it is required by a standard library method, we will add it. If it is not, even if it's a popular library from PyPI, we will not. |
|
Can you help me understand what you mean by “standard library method”?On Oct 29, 2024, at 1:30 AM, Bernát Gábor ***@***.***> wrote:
Closed #3429 as not planned.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
My last email reply was truncated, and one email reply seems to not have been posted. Here is documentation from Microsoft on the Windows Win32 API that lists LOCALAPPDATA as "standard" from shellapi.h. This blog post explains Windows installer target path logic including this environment variable. |
|
Is there a method in the Python standard library that requires this environment to function correctly? |
|
In my opinion you need to separate a language from the standard patterns found in operating systems where that language is commonly used. As a developer that writes software for users of an operating system, you have to follow the standard patterns found on that operating system. For POSIX based systems you can use the ubiquitous $HOME or tilde (~) to find user local paths. On Windows you have to use environment variables for software installed for either all users (APPDATA) or a single user (LOCALAPPDATA). In my humble opinion, I think you need to expand your definition of "standard" to include the target operating environment, not just Python itself. That said, if you require a Python specific tie in, then please read Using Python on Windows from the official Python GitHub repo. It references this environment variable. |
|
We will need to agree to disagree on this one. Also note that this doesn't stop you from using the tool, you just have to set that environmental variable in your configuration should you use a library requiring this environment variable. My definition of where I draw the line in the sand is not "mentioned in the documentation" but rather used by the Python interpreter itself or its standard library. |
Issue
This is related to #3151 - LOCALAPPDATA is needed just as APPDATA is needed. It is a commonly used Windows environment variable and it is used by popular Python packages such as python-certifi-win32.
Environment
Output of running tox
Output of
tox -rvvMinimal example
No specific example. The LOCALAPPDATA environment variable has to be manually included via
pass_env. If APPDATA is considered an automatically included variable on Windows, then LOCALAPPDATA should be included as well.The text was updated successfully, but these errors were encountered: