-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On Windows APPDATA is missing in os.environ #3151
Comments
You can add it by passing it via |
It is not a stdlib method but Python packages. Also |
Ah, if needed only for click is an app specific setting you should add in your tox.ini yourself. Make sure you read https://tox.wiki/en/4.11.3/upgrading.html#packaging-environments, and note doing |
@gaborbernat I only provided click as a example. There are many packages that requires this. I also managed to get But I must say.. It is VERY bad behaviour to modify the actual standard Windows paths that are expected to be available as packages use to generate a temp path. In my case It failed in a install of my package because it uses setuptools_scm for pulling version for it. I do understand it being done doing testing but doing it before the actual testing is just gonna be a potential case of many issues. BUT i would highly prefer a proper solution to this. |
Unless this is needed for a standard library functionality, I will have to disagree with your point of view. |
But PIP is a VERY important part of Python and is installed per default thus this should be 100% compatible with pip I haven't sat down and figured out exactly what in pip is using the |
@Stefanhg Do you think you find the time to dig deeper how pip uses that env var? |
@jugmac00 I just took a look at it. In |
PR welcome. |
@gaborbernat Can you then mark the issue as open and help wanted as all of the other issues if you agree that there is a issue here? |
I have a fix ready. Just need to make the PR when I get home from work. |
Issue resolved with newest release (4.11.4) |
Issue
os.environ is missing APPDATA which are used in some methods.
Issue was initially reproduced in setuptools_scm
pypa/setuptools-scm#861
I have attached a .zip file that includes the example used to reproduce the issue.
If i just run pytest alone the test passes.
It works until version 3.28.0
Environment
Provide at least:
Output of
pip list
of the host Python, wheretox
is installedOutput of running tox
Output of
tox -rvv
Minimal example
test_tox.zip
The text was updated successfully, but these errors were encountered: