Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable or disable Crush with a button #83

Merged
merged 14 commits into from
Jul 11, 2023
Merged

Enable or disable Crush with a button #83

merged 14 commits into from
Jul 11, 2023

Commits on Jul 11, 2023

  1. Cleanup: Extract getting value->string to function 

    This and the next related commits originally supported
a change to how value text is displayed for Crush parameter
values. I dropped that change, but this little refactor is
still a good idea.
    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    73fec49 View commit details
    Browse the repository at this point in the history

  2. Cleanup: Extract getting a precision adjusted value string to function

    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    cccd5ca View commit details
    Browse the repository at this point in the history

  3. Cleanup: Use precision adjusted string for displaying ratio values

    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    09db500 View commit details
    Browse the repository at this point in the history

  4. Cleanup: Move value string function into audio param construction 

    Optimization...?
    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    21f6ab4 View commit details
    Browse the repository at this point in the history

  5. Cleanup: Use juce::roundToInt instead of simple cast 

    It's more accurate!
    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    f76c131 View commit details
    Browse the repository at this point in the history

  6. Cleanup: Rename OutputClip parameter enum and id OutputClipEnable

    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    6a2ca81 View commit details
    Browse the repository at this point in the history

  7. Add a parameter for Crush enablement

    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    b10c6fd View commit details
    Browse the repository at this point in the history

  8. Cleanup: Don't use hardcoded text for Clip enable button

    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d53d3ee View commit details
    Browse the repository at this point in the history

  9. Implement a drawable button for Crush enable

    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    f6be6f8 View commit details
    Browse the repository at this point in the history

  10. Cleanup: Apply new clang-format to ParameterTextButton.cpp

    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    fd05e97 View commit details
    Browse the repository at this point in the history

  11. Cleanup: Tweak placement of Clip enable button

    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    83eed22 View commit details
    Browse the repository at this point in the history

  12. Make top row a little bigger to accomodate buttons

    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    be7521a View commit details
    Browse the repository at this point in the history

  13. Cleanup: Add new clang-format to look and feel

    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    9d60c52 View commit details
    Browse the repository at this point in the history

  14. Cleanup: Use detail namespace in plugin processor instead of anonymous 

    Use of anonymous namespace gives the variables and functions declared
there global scope, which is kind of the opposite of what I wanted.
    @JoseDiazRohena
    JoseDiazRohena committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    914c44d View commit details
    Browse the repository at this point in the history