Enable or disable Crush with a button #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseDiazRohena
force-pushed
the
crush-off-state
branch
5 times, most recently
from
061073a
to
78b19f0
Compare
JoseDiazRohena
force-pushed
the
crush-off-state
branch
from
78b19f0
to
8be1b18
Compare
This and the next related commits originally supported a change to how value text is displayed for Crush parameter values. I dropped that change, but this little refactor is still a good idea.
JoseDiazRohena
force-pushed
the
crush-off-state
branch
from
8be1b18
to
00e9afb
Compare
Optimization...?
It's more accurate!
JoseDiazRohena
force-pushed
the
crush-off-state
branch
3 times, most recently
from
c62e58f
to
39836e8
Compare
Use of anonymous namespace gives the variables and functions declared there global scope, which is kind of the opposite of what I wanted.
JoseDiazRohena
force-pushed
the
crush-off-state
branch
from
39836e8
to
914c44d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow for change to Crush enablement with the press of a button.
Previously, this was accomplished by tweaking the Crush parameter range such that values
at the very beginning of the range shut off processing. This is kind of hard to follow in the code
and also makes it hark to get values exactly at the minimum crush amount.
Now, the smallest parameter value processes at the Crush effect minimum. Pressing the new
button turns the effect on and off.
There are also some cleanups I ran into on the way.