Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path resolution error by updating #74

Merged
merged 3 commits into from
Jul 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/rich-otters-fry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"overlay-kit": patch
"@overlay-kit/framer-motion-react-16": patch
"@overlay-kit/framer-motion-react-17": patch
---

Fix path resolution error by updating import path for 'use-sync-external-store/shim'

The import path for `use-sync-external-store/shim` was incorrect, causing a path resolution error during build. This change updates the import statement to include `index.js`, resolving the path issue.
2 changes: 1 addition & 1 deletion examples/react-16/framer-motion/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"dependencies": {
"framer-motion": "^6",
"overlay-kit": "1.4.0",
"overlay-kit": "npm:overlay-kit@1.4.0-canary.2407260853",
"react": "^16.8",
"react-dom": "^16.8"
},
Expand Down
2 changes: 1 addition & 1 deletion examples/react-17/framer-motion/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
},
"dependencies": {
"framer-motion": "^6",
"overlay-kit": "1.4.0",
"overlay-kit": "npm:overlay-kit@1.4.0-canary.2407260853",
"react": "^17",
"react-dom": "^17"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/src/context/use-sync-overlay-store.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useSyncExternalStore } from 'use-sync-external-store/shim';
import { useSyncExternalStore } from 'use-sync-external-store/shim/index.js';
import { registerOverlaysStore } from './store';

export function useSyncOverlayStore() {
Expand Down
18 changes: 15 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1442,7 +1442,7 @@ __metadata:
"@types/react-dom": "npm:^16.8"
"@vitejs/plugin-react": "npm:^4.3.0"
framer-motion: "npm:^6"
overlay-kit: "npm:1.4.0"
overlay-kit: "npm:overlay-kit@1.4.0-canary.2407260853"
react: "npm:^16.8"
react-dom: "npm:^16.8"
typescript: "npm:^5.4.5"
Expand All @@ -1458,7 +1458,7 @@ __metadata:
"@types/react-dom": "npm:^17"
"@vitejs/plugin-react": "npm:^4.3.0"
framer-motion: "npm:^6"
overlay-kit: "npm:1.4.0"
overlay-kit: "npm:overlay-kit@1.4.0-canary.2407260853"
react: "npm:^17"
react-dom: "npm:^17"
typescript: "npm:^5.4.5"
Expand Down Expand Up @@ -5747,7 +5747,19 @@ __metadata:
languageName: node
linkType: hard

"overlay-kit@npm:1.4.0, overlay-kit@workspace:^, overlay-kit@workspace:packages":
"overlay-kit@npm:overlay-kit@1.4.0-canary.2407260853":
version: 1.4.0-canary.2407260853
resolution: "overlay-kit@npm:1.4.0-canary.2407260853"
dependencies:
use-sync-external-store: "npm:^1.2.2"
peerDependencies:
react: ^16.8.0 || ^17.0.0 || ^18.0.0
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0
checksum: 10c0/da27ad566839a975a6f56a4544b53d0e260b6b13e23b218b0cf370e5c8f7a7cb80930792f2ada5a9d6704b082b5e62d89510d37ba5bf186f8af94c9b431775b8
languageName: node
linkType: hard

"overlay-kit@workspace:^, overlay-kit@workspace:packages":
version: 0.0.0-use.local
resolution: "overlay-kit@workspace:packages"
dependencies:
Expand Down