Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path resolution error by updating #74

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

jungpaeng
Copy link
Member

Description

The import path for use-sync-external-store/shim was incorrect, causing a path resolution error during build. This change updates the import statement to include index.js, resolving the path issue.

Changes

  • Updated the import statement in use-sync-overlay-store.ts to use-sync-external-store/shim/index.js.

Motivation and Context

This change is necessary to resolve a path resolution error that was preventing the build process from completing successfully. By specifying the correct import path, we ensure that the required module is correctly located and imported.

How Has This Been Tested?

  • Verified that the application builds successfully after the change.
  • Tested the functionality that depends on use-sync-external-store to ensure it works as expected.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have performed a self-review of my own code.
  • My code is commented, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Further Comments

@jungpaeng jungpaeng self-assigned this Jul 28, 2024
Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlay-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 8:53am

Copy link

changeset-bot bot commented Jul 28, 2024

🦋 Changeset detected

Latest commit: b262616

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
overlay-kit Patch
@overlay-kit/framer-motion-react-16 Patch
@overlay-kit/framer-motion-react-17 Patch
@overlay-kit/framer-motion-react-18 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jungpaeng jungpaeng changed the title Fix/use sync external store path fix: path resolution error by updating Jul 28, 2024
@jungpaeng jungpaeng force-pushed the fix/use-sync-external-store-path branch from 0c50d8b to dc24f27 Compare July 28, 2024 08:52
jungpaeng and others added 3 commits July 28, 2024 17:52
…-external-store/shim'

- Updated the import statement to explicitly include 'index.js' in the path for 'use-sync-external-store/shim'.
- This resolves the issue where the source path could not be accessed due to incorrect import resolution.

Co-authored-by: Jonghyeon Ko <61593290+manudeli@users.noreply.github.com>
@jungpaeng jungpaeng force-pushed the fix/use-sync-external-store-path branch from dc24f27 to b262616 Compare July 28, 2024 08:53
@jungpaeng jungpaeng merged commit 324dab9 into main Jul 28, 2024
1 of 2 checks passed
@jungpaeng jungpaeng deleted the fix/use-sync-external-store-path branch July 28, 2024 08:53
@github-actions github-actions bot mentioned this pull request Jul 28, 2024
@manudeli
Copy link
Member

@jungpaeng You co-authored me in 3ae8b9a

Thanks! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants