-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issues with v2 #44
Conversation
ACK 19437dd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @grmbyrn, just a couple of comments:
- I'm closing only the issues I consider finished 100%. I commented on the ones I think there are pending things to do.
- Make sure the linter passes before opening the PR and fix it if it fails after opening the PR.
- Make sure to follow the design as much as possible (pixel). I think it's very important to implement exactly what the designers gave us. They have their reasons and in my opinion the final site looks much worse with many mini changes.
That's no problem. For the linters, I ran them before and had no error. The error after opening the PR indicates an issue in |
In those cases you can run I guess you mean this: |
TorrustIndexPost.svelte
andTorrustTrackerPost.svelte