Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with v2 #44

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix issues with v2 #44

merged 2 commits into from
Sep 25, 2024

Conversation

@josecelano
Copy link
Member

ACK 19437dd

Copy link
Member

@josecelano josecelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @grmbyrn, just a couple of comments:

  1. I'm closing only the issues I consider finished 100%. I commented on the ones I think there are pending things to do.
  2. Make sure the linter passes before opening the PR and fix it if it fails after opening the PR.
  3. Make sure to follow the design as much as possible (pixel). I think it's very important to implement exactly what the designers gave us. They have their reasons and in my opinion the final site looks much worse with many mini changes.

@josecelano josecelano merged commit aec6ce6 into torrust:develop Sep 25, 2024
1 check failed
@grmbyrn
Copy link
Collaborator Author

grmbyrn commented Sep 25, 2024

Good job @grmbyrn, just a couple of comments:

  1. I'm closing only the issues I consider finished 100%. I commented on the ones I think there are pending things to do.
  2. Make sure the linter passes before opening the PR and fix it if it fails after opening the PR.
  3. Make sure to follow the design as much as possible (pixel). I think it's very important to implement exactly what the designers gave us. They have their reasons and in my opinion the final site looks much worse with many mini changes.

That's no problem. For the linters, I ran them before and had no error. The error after opening the PR indicates an issue in Hero.svelte but nothing comes up when I check it.

@josecelano
Copy link
Member

Good job @grmbyrn, just a couple of comments:

  1. I'm closing only the issues I consider finished 100%. I commented on the ones I think there are pending things to do.
  2. Make sure the linter passes before opening the PR and fix it if it fails after opening the PR.
  3. Make sure to follow the design as much as possible (pixel). I think it's very important to implement exactly what the designers gave us. They have their reasons and in my opinion the final site looks much worse with many mini changes.

That's no problem. For the linters, I ran them before and had no error. The error after opening the PR indicates an issue in Hero.svelte but nothing comes up when I check it.

In those cases you can run npm run format and check is there was a git change (git status). I don't know why it's not showing the error.

I guess you mean this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment