Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review design for table of contents in blog posts #8

Open
josecelano opened this issue Sep 23, 2024 · 3 comments
Open

Review design for table of contents in blog posts #8

josecelano opened this issue Sep 23, 2024 · 3 comments
Assignees
@grmbyrn
Milestone
v3.1.0

Comments

@josecelano
Copy link
Member

josecelano commented Sep 23, 2024 •
edited
Loading

In the original design, Fer did not use any char at the beginning of the title of the table of contents item. We are using #. Do we need that char @grmbyrn?

Current

image

Expected

image
@josecelano josecelano assigned josecelano and grmbyrn and unassigned josecelano Sep 23, 2024
@grmbyrn grmbyrn mentioned this issue Sep 25, 2024
Merged
@josecelano josecelano linked a pull request Sep 25, 2024 that will close this issue
fix issues with v2 #44
Merged
@josecelano
Copy link
Member Author

Hi @grmbyrn in this PR, some articles still have a table of contents with the # prefix.

http://localhost:5173/torrust-enhancing-the-bittorrent-ecosystem

image

@josecelano josecelano removed a link to a pull request Sep 25, 2024
fix issues with v2 #44
Merged
@grmbyrn
Copy link
Collaborator

grmbyrn commented Sep 25, 2024

Hi @grmbyrn in this PR, some articles still have a table of contents with the # prefix.

http://localhost:5173/torrust-enhancing-the-bittorrent-ecosystem

image

Hi @josecelano at the moment the blog posts are using a different table of contents set up. I've got it to work on pages but will need to see if it works on Markdown.

@grmbyrn grmbyrn pinned this issue Sep 25, 2024
@grmbyrn grmbyrn unpinned this issue Sep 25, 2024
josecelano added a commit that referenced this issue Sep 25, 2024
@josecelano
Merge #44: fix issues with v2
aec6ce6 
19437dd Fix conflict issues (Graeme Byrne)
5c2e1df fix issues with v2 (Graeme Byrne)

Pull request description:

  * moved posts for index and tracker into `TorrustIndexPost.svelte` and `TorrustTrackerPost.svelte`
  * [Key features list width should be 100% #6](#6)
  * [Review design for table of contents #8](#8)
  * [Minor bugs in homepage #12](#12)
  * [Homepage cards don't have the same padding as design #25](#25)
  * [Top menu padding is not the same as the design #26](#26)
  * [Related Post section does not look like the standard blog post list #27](#27)
  * [Ask the designer how we should implement navigation between blog posts #28](#28)
  * [Ask the designer how to implement share links in blog posts #29](#29)
  * [Remove # prefix from titles #30](#30)
  * [Ask the designer how to implement highlighted terms or sentences in markdown #36](#36)
  * [Font style in feature card is not the same as in the original design #43](#43)

ACKs for top commit:
  josecelano:
    ACK 19437dd

Tree-SHA512: a60b8ee60753f8517ddd53ae1073d97b481b9badbc75938f364b0c239ab561a6b2eece7d01f5c4ff4e97af9804facfb04e8266377a32ce4a27c531dcf5263044
@josecelano josecelano changed the title Review design for table of contents Review design for table of contents in blog posts Sep 25, 2024
@josecelano
Copy link
Member Author

Hi @grmbyrn in this PR, some articles still have a table of contents with the # prefix.
http://localhost:5173/torrust-enhancing-the-bittorrent-ecosystem
image

Hi @josecelano at the moment the blog posts are using a different table of contents set up. I've got it to work on pages but will need to see if it works on Markdown.

Ok @grmbyrn we can keep the issue until it's fixed for this case. I've updated the title.

@josecelano josecelano modified the milestones: v3.0.0, v3.1.0 Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grmbyrn grmbyrn

Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

No branches or pull requests
2 participants
@josecelano @grmbyrn