Improve startup performance

extension/data/modules/achievements.js

@@ -314,4 +314,6 @@ function achievements () {
 
 window.addEventListener('TBModuleLoaded', () => {
     achievements();
+}, {
+    once: true,
 });

extension/data/modules/betterbuttons.js

@@ -518,4 +518,6 @@ function betterbuttons () {
 
 window.addEventListener('TBModuleLoaded', () => {
     betterbuttons();
+}, {
+    once: true,
 });

extension/data/modules/comment.js

@@ -548,4 +548,6 @@ function comments () {
 
 window.addEventListener('TBModuleLoaded', () => {
     comments();
+}, {
+    once: true,
 });

extension/data/modules/config.js

@@ -340,7 +340,7 @@ function tbconfig () {
             subreddit = $(this).data('subreddit');
 
             TBApi.readFromWiki(subreddit, 'toolbox', true).then(resp => {
-                if (!resp || resp === TBCore.WIKI_PAGE_UNKNOWN || resp === TBCore.NO_WIKI_PAGE) {
+                if (!resp || resp === TBApi.WIKI_PAGE_UNKNOWN || resp === TBApi.NO_WIKI_PAGE) {
                     self.log('Failed: wiki config');
 
                     config = TBCore.config;
@@ -498,13 +498,13 @@ function tbconfig () {
                 });
 
                 TBApi.readFromWiki(subreddit, actualPage, false).then(resp => {
-                    if (resp === TBCore.WIKI_PAGE_UNKNOWN) {
+                    if (resp === TBApi.WIKI_PAGE_UNKNOWN) {
                         $textArea.val('error getting wiki data.');
                         configEditor.setValue('error getting wiki data.');
                         return;
                     }
 
-                    if (resp === TBCore.NO_WIKI_PAGE) {
+                    if (resp === TBApi.NO_WIKI_PAGE) {
                         $textArea.val('');
                         configEditor.setValue('');
                         $saveButton.show();
@@ -531,12 +531,12 @@ function tbconfig () {
                 $textArea.val('getting wiki data...');
 
                 TBApi.readFromWiki(subreddit, actualPage, false).then(resp => {
-                    if (resp === TBCore.WIKI_PAGE_UNKNOWN) {
+                    if (resp === TBApi.WIKI_PAGE_UNKNOWN) {
                         $textArea.val('error getting wiki data.');
                         return;
                     }
 
-                    if (resp === TBCore.NO_WIKI_PAGE) {
+                    if (resp === TBApi.NO_WIKI_PAGE) {
                         $textArea.val('');
                         $saveButton.show();
                         $saveButton.attr('page', page);
@@ -903,7 +903,7 @@ function tbconfig () {
                 // determine if we want to pull a new config, we only do this if the toolbox config wiki has been edited.
                 if ($body.hasClass('toolbox-wiki-edited')) {
                     TBApi.readFromWiki(subreddit, 'toolbox', true).then(resp => {
-                        if (!resp || resp === TBCore.WIKI_PAGE_UNKNOWN || resp === TBCore.NO_WIKI_PAGE) {
+                        if (!resp || resp === TBApi.WIKI_PAGE_UNKNOWN || resp === TBApi.NO_WIKI_PAGE) {
                             self.log('Failed: wiki config');
                             return;
                         }
@@ -1053,7 +1053,7 @@ function tbconfig () {
                 // determine if we want to pull a new config, we only do this if the toolbox config wiki has been edited.
                 if ($body.hasClass('toolbox-wiki-edited')) {
                     TBApi.readFromWiki(subreddit, 'toolbox', true).then(resp => {
-                        if (!resp || resp === TBCore.WIKI_PAGE_UNKNOWN || resp === TBCore.NO_WIKI_PAGE) {
+                        if (!resp || resp === TBApi.WIKI_PAGE_UNKNOWN || resp === TBApi.NO_WIKI_PAGE) {
                             self.log('Failed: wiki config');
                             return;
                         }
@@ -1247,7 +1247,7 @@ function tbconfig () {
             // determine if we want to pull a new config, we only do this if the toolbox config wiki has been edited.
             if ($body.hasClass('toolbox-wiki-edited')) {
                 TBApi.readFromWiki(subreddit, 'toolbox', true).then(resp => {
-                    if (!resp || resp === TBCore.WIKI_PAGE_UNKNOWN || resp === TBCore.NO_WIKI_PAGE) {
+                    if (!resp || resp === TBApi.WIKI_PAGE_UNKNOWN || resp === TBApi.NO_WIKI_PAGE) {
                         self.log('Failed: wiki config');
                         return;
                     }
@@ -1330,7 +1330,7 @@ function tbconfig () {
                 // determine if we want to pull a new config, we only do this if the toolbox config wiki has been edited.
                 if ($body.hasClass('toolbox-wiki-edited')) {
                     TBApi.readFromWiki(subreddit, 'toolbox', true).then(resp => {
-                        if (!resp || resp === TBCore.WIKI_PAGE_UNKNOWN || resp === TBCore.NO_WIKI_PAGE) {
+                        if (!resp || resp === TBApi.WIKI_PAGE_UNKNOWN || resp === TBApi.NO_WIKI_PAGE) {
                             self.log('Failed: wiki config');
                             return;
                         }
@@ -1621,4 +1621,6 @@ function tbconfig () {
 
 window.addEventListener('TBModuleLoaded', () => {
     tbconfig();
+}, {
+    once: true,
 });

extension/data/modules/devtools.js

@@ -192,4 +192,6 @@ function devtools () {
 
 window.addEventListener('TBModuleLoaded', () => {
     devtools();
+}, {
+    once: true,
 });

extension/data/modules/domaintagger.js

@@ -250,11 +250,11 @@ function domaintagger () {
             let {config} = TBCore;
 
             TBApi.readFromWiki(subreddit, 'toolbox', true).then(resp => {
-                if (resp === TBCore.WIKI_PAGE_UNKNOWN) {
+                if (resp === TBApi.WIKI_PAGE_UNKNOWN) {
                     return;
                 }
 
-                if (resp === TBCore.NO_WIKI_PAGE) {
+                if (resp === TBApi.NO_WIKI_PAGE) {
                     config.domainTags = [domainTag];
                     postToWiki(subreddit, config, 'domain tagger: create new toolbox config');
                     return;
@@ -314,4 +314,6 @@ function domaintagger () {
 
 window.addEventListener('TBModuleLoaded', () => {
     domaintagger();
+}, {
+    once: true,
 });

extension/data/modules/flyingsnoo.js

@@ -139,4 +139,6 @@ function flyingsnoo () {
 
 window.addEventListener('TBModuleLoaded', () => {
     flyingsnoo();
+}, {
+    once: true,
 });

extension/data/modules/general.js

@@ -62,4 +62,6 @@ function generalSettings () {
 
 window.addEventListener('TBModuleLoaded', () => {
     generalSettings();
+}, {
+    once: true,
 });

extension/data/modules/historybutton.js

@@ -826,4 +826,6 @@ function historybutton () {
 
 window.addEventListener('TBModuleLoaded', () => {
     historybutton();
+}, {
+    once: true,
 });

extension/data/modules/macros.js

@@ -21,13 +21,13 @@ function modmacros () {
                 callback(checkConfig(TBCore.configCache[sub]), TBCore.configCache[sub].modMacros);
             } else {
                 TBApi.readFromWiki(sub, 'toolbox', true).then(resp => {
-                    if (!resp || resp === TBCore.WIKI_PAGE_UNKNOWN) {
-                        self.log('!resp || resp === TBCore.WIKI_PAGE_UNKNOWN');
+                    if (!resp || resp === TBApi.WIKI_PAGE_UNKNOWN) {
+                        self.log('!resp || resp === TBApi.WIKI_PAGE_UNKNOWN');
                         callback(false);
                     }
 
-                    if (resp === TBCore.NO_WIKI_PAGE) {
-                        self.log('resp === TBCore.NO_WIKI_PAGE');
+                    if (resp === TBApi.NO_WIKI_PAGE) {
+                        self.log('resp === TBApi.NO_WIKI_PAGE');
                         TBCore.updateCache('noConfig', sub, false);
                         callback(false);
                     }
@@ -554,4 +554,6 @@ function modmacros () {
 
 window.addEventListener('TBModuleLoaded', () => {
     modmacros();
+}, {
+    once: true,
 });

extension/data/modules/modbar.js

@@ -538,6 +538,8 @@ function modbar () {
 
 window.addEventListener('TBModuleLoaded', () => {
     modbar();
+}, {
+    once: true,
 });
 function getDirectingTo () {
     let url = window.location.href.replace(/^http:/, 'https:'),

extension/data/modules/modbutton.js

@@ -684,4 +684,6 @@ function modbutton () {
 
 window.addEventListener('TBModuleLoaded', () => {
     modbutton();
+}, {
+    once: true,
 });

extension/data/modules/modmailpro.js

@@ -1048,4 +1048,6 @@ function modmailpro () {
 
 window.addEventListener('TBModuleLoaded', () => {
     modmailpro();
+}, {
+    once: true,
 });

extension/data/modules/modmatrix.js

@@ -796,4 +796,6 @@ ${renderedMarkdown}
 
 window.addEventListener('TBModuleLoaded', () => {
     modmatrix();
+}, {
+    once: true,
 });

extension/data/modules/newmodmailpro.js

@@ -515,4 +515,6 @@ function newmodmailpro () {
 
 window.addEventListener('TBModuleLoaded', () => {
     newmodmailpro();
+}, {
+    once: true,
 });

extension/data/modules/notifier.js

@@ -786,4 +786,6 @@ function notifiermod () {
 
 window.addEventListener('TBModuleLoaded', () => {
     notifiermod();
+}, {
+    once: true,
 });

extension/data/modules/nukecomments.js

@@ -274,4 +274,6 @@ function nukecomments () {
 
 window.addEventListener('TBModuleLoaded', () => {
     nukecomments();
+}, {
+    once: true,
 });

extension/data/modules/oldreddit.js

@@ -239,6 +239,7 @@ function oldReddit () {
     }
 
     self.init = function () {
+        profileResults('oldRedditInit', performance.now());
         // Looks like we are on old reddit. Activate!
         if (TBCore.isOldReddit) {
             setTimeout(() => {
@@ -247,7 +248,7 @@ function oldReddit () {
                 window.addEventListener('TBNewThings', () => {
                     thingCrawler();
                 });
-            }, 500);
+            }, 10);
         }
 
         if (TBCore.isNewModmail) {
@@ -267,16 +268,27 @@ function oldReddit () {
 
             window.addEventListener('TBNewPage', event => {
                 if (event.detail.pageType === 'modmailConversation') {
-                    setTimeout(() => {
-                        newModmailSidebar();
-                        newModmailConversationAuthors();
-                    }, 500);
+                    // We want to show buttons as soone as possible.
+                    // New modmail loading times are less than reliable at times.
+                    // So we simply check multiple times in a row to show things as soon as possible.
+                    const timeoutArray = [50, 500, 1500];
+                    timeoutArray.forEach(timeout => {
+                        setTimeout(() => {
+                            newModmailSidebar();
+                            newModmailConversationAuthors();
+                        }, timeout);
+                    });
                 }
             });
         }
+        profileResults('oldRedditInitDone', performance.now());
     };
 }
 
 window.addEventListener('TBModuleLoaded', () => {
+    profileResults('oldRedditStart', performance.now());
     oldReddit();
+    profileResults('oldRedditDone', performance.now());
+}, {
+    once: true,
 });

extension/data/modules/personalnotes.js

@@ -72,13 +72,13 @@ function personalnotes () {
             $editArea.css('display', 'block');
 
             TBApi.readFromWiki(notewiki, `notes/${wikiPage}`, false).then(resp => {
-                if (resp === TBCore.WIKI_PAGE_UNKNOWN) {
+                if (resp === TBApi.WIKI_PAGE_UNKNOWN) {
                     $editArea.val('error getting wiki data.');
                     TB.ui.textFeedback('error getting wiki data.', TB.ui.FEEDBACK_NEGATIVE);
                     return;
                 }
 
-                if (resp === TBCore.NO_WIKI_PAGE) {
+                if (resp === TBApi.NO_WIKI_PAGE) {
                     $editArea.val('Not sure how you did this, but this is not an existing page.');
                     TB.ui.textFeedback('error getting wiki data.', TB.ui.FEEDBACK_NEGATIVE);
                     return;
@@ -295,4 +295,6 @@ function personalnotes () {
 
 window.addEventListener('TBModuleLoaded', () => {
     personalnotes();
+}, {
+    once: true,
 });

extension/data/modules/profile.js

@@ -923,4 +923,6 @@ function profilepro () {
 
 window.addEventListener('TBModuleLoaded', () => {
     profilepro();
+}, {
+    once: true,
 });

extension/data/modules/queue_overlay.js

@@ -309,4 +309,6 @@ function queueOverlay () {
 
 window.addEventListener('TBModuleLoaded', () => {
     queueOverlay();
+}, {
+    once: true,
 });

extension/data/modules/queuetools.js

@@ -380,12 +380,12 @@ function queuetools () {
                     <p><label><input type="checkbox" class="choice" name="links" /> submissions</label></p>
                     <p><label><input type="checkbox" class="choice" name="self" /> text posts</label></p>
                     <p><label><input type="checkbox" class="choice" name="flair" /> posts with flair</label></p>
-                    
+
                     <p class="divider"><input type="text" class="choice tb-input" name="domain" placeholder="domain..." /></p>
                     <p><input type="text" class="choice tb-input" name="user" placeholder="user..." /></p>
                     <p><input type="text" class="choice tb-input" name="title" placeholder="title..." /></p>
                     <p><input type="text" class="choice tb-input" name="subreddit" placeholder="subreddit..." /></p>
-                    
+
                     <h2 class="divider">Conditional</h2>
                     <p><input type="text" class="choice tb-input" name="pointsgt" placeholder="points >..." /></p>
                     <p><input type="text" class="choice tb-input" name="pointslt" placeholder="points <..." /></p>
@@ -1439,4 +1439,6 @@ Action reason: ${value.data.details}
 
 window.addEventListener('TBModuleLoaded', () => {
     queuetools();
+}, {
+    once: true,
 });

extension/data/modules/removalreasons.js

@@ -135,7 +135,7 @@ function removalreasons () {
 
             // OK, they are not cached.  Try the wiki.
             TBApi.readFromWiki(subreddit, 'toolbox', true).then(resp => {
-                if (!resp || resp === TBCore.WIKI_PAGE_UNKNOWN || resp === TBCore.NO_WIKI_PAGE || !resp.removalReasons) {
+                if (!resp || resp === TBApi.WIKI_PAGE_UNKNOWN || resp === TBApi.NO_WIKI_PAGE || !resp.removalReasons) {
                     self.log('failed: wiki config');
                     callback(false);
                     return;
@@ -938,4 +938,6 @@ function removalreasons () {
 
 window.addEventListener('TBModuleLoaded', () => {
     removalreasons();
+}, {
+    once: true,
 });

extension/data/modules/support.js

@@ -85,4 +85,6 @@ Info|  
 
 window.addEventListener('TBModuleLoaded', () => {
     support();
+}, {
+    once: true,
 });

extension/data/modules/syntax.js

@@ -284,4 +284,6 @@ function syntax () {
 
 window.addEventListener('TBModuleLoaded', () => {
     syntax();
+}, {
+    once: true,
 });

extension/data/modules/trouble.js

@@ -241,4 +241,6 @@ function trouble () {
 
 window.addEventListener('TBModuleLoaded', () => {
     trouble(); // run
+}, {
+    once: true,
 });