Improve startup performance #408

creesch · 2020-10-24T12:01:02Z

Still a draft but from initial testing it seems to make 1-2 seconds depending on circumstances. Effectively it moves the API calls to get user information forward so they can get started before the DOM is in an interactive state. I also moved most javascript around in the manifest so it should be loaded sooner.

Still a bit of a draft as I put in a lot of console log statements with performance.now() timestamps to get insights in delays and I still need to investigate a few things.

I also did play around with replacing all $body declarations with one TBCore variant with the idea that this might improve performance but that doesn't seem to any impact (maybe in memory usage though, didn't look into that).

I also checked if disabling modules like betterbuttons which still scrape the page in an oldschool way had an effect but that also doesn't seem to be the case.

There is still some more investigating to do to see if we can get out a bit more performance but all things considered from what I can see a lot of the perceived delays is mostly down to the sheer amount of things toolbox does with reddit.

On a final note, on firefox performance seems slightly better compared to chromium based browsers both in visual aspect as in actual numbers.

eritbh

Mostly makes sense to me so far. Left some thoughts.

eritbh · 2020-11-17T15:15:05Z

extension/data/modules/oldreddit.js

                }
            });
        }
+        profileResults('oldRedditInitDone', performance.now());


This profile is basically useless since all that's being done between here and oldRedditInit is setting a bunch of timeouts.

eritbh · 2020-11-17T15:17:14Z

extension/data/tbapi.js

+
+    TBApi.setModHash = modhash => {
+        TBApi.modhash = modhash;
+    };


Er... why does this function exist...?

To set the modhash :P Has to do with how toolbox is structured, when TBApi is loaded in the modhash isn't known yet. I wanted a clean way to set it once it is known.

Can we not just do TBApi.modhash = stuff from wherever the modhash is retreived?

Possibly, but afaik we never directly update class/object values so this did seem like a bit cleaner. There also might have been a technical reason I convinced myself was there, but I can't remember now....

eritbh · 2020-11-17T15:18:33Z

extension/data/tbcore.js

@@ -4,22 +4,22 @@ function initwrapper ({userDetails, newModSubs, cacheDetails}) {
    (function (TBCore) {
        // We need these before we can do anything.
        TBCore.userDetails = userDetails;
-        TBCore.modhash = userDetails.data.modhash;
+        TBCore.modhash = TBApi.modhash;


We should really only store this value in one place, why not just replace all TBCore.modhash with TBApi.modhash?

Hrm not sure why I did it like this to be honest...

extension/data/tbcore.js

eritbh · 2020-11-17T15:25:41Z

extension/data/tbui.js

-    TBui.getBestTextColor.cache = {};
-})(window.TBui = window.TBui || {});
+if (document.readyState === 'loading') {
+    document.addEventListener('readystatechange', TBuiInitWrapper, {


Shouldn't this be restricted to only run for a certain ready state?

Nope, as long as it isn't loading it is fine.

Hm, so it seems like it's always being called on interactive then. I'd rather call out the state we're targeting explicitly, but that might be too small a nitpick. I see how it works now.

Frankly seemed like a wasted check as it really doesn't matter as long as it isn't loading.

extension/data/tbui.js

extension/manifest.json

eritbh · 2020-11-17T15:32:40Z

extension/data/tbstorage.js

+                    logger.error('firefox is in incognito mode, toolbox will not work.');
+                    return;
+                }
+                console.log('sendInit7', performance.now());


will probably want to remove these logs eventually

extension/data/tbcore.js

Co-authored-by: Geo <georgej1088@gmail.com>

…/reddit-moderator-toolbox into startup-performance

creesch · 2020-11-18T07:25:18Z

Aside from the obvious stuff that still needs fixing before we merge this I do want to try to get some actual benchmarks with enough datapoints with a few scenarios to see actual benefits. Specifically I came across a article regarding performance from a chrome developer where it was pointed out that changing the DOM while it is still being rendered might actually hurt performance.

With that in mind I still want to experiment with some specific scenarios and try to get tangible date points:

Baseline, master as it is now without the above scenarios.
Current PR.
Current PR with CSS moved to load earlier.
Current PR but a change where we don't do the complete init at interactive but ready
Same as above but with the CSS moved.

I'd like to try to not only measure reported load times but also visible load times, at what point do we see toolbox being loaded. To that end I'll probably set up a simple test with selenium.

eritbh · 2022-07-13T19:08:37Z

This branch hadn't been updated since before #518 (content script esm) so it was very outdated. I got bored and merged current master back into it; a lot of the original performance changes that were in this branch were tied directly to the old event-based module registration system, so they're not here anymore, but there are a couple changes still relevant:

Using a single $body variable rather than recomputing $('body') in some spots
Removing TBCore.NO_WIKI_PAGE etc which were just unnecessary re-exported duplicates of the same on TBApi

Diff is much smaller now, could probably be a pretty easy merge.

* move init api calls, shuffle timing * $body = $body doesn't work. * Move api specific constants to TBApi * remove weird $body usage * Make sure tbui gets loaded at the right time. * Not sure how this got back in there. * Improve new modmail performance and reliability. * Only listen to init events once * Better diff for geo ;) * Update extension/data/tbcore.js Co-authored-by: Geo <georgej1088@gmail.com> * Disable travis unit tests * Finish moving off TBCore errors and remove them Co-authored-by: Geo <georgej1088@gmail.com> Co-authored-by: Erin <erin20913@gmail.com>

creesch added 7 commits October 24, 2020 13:16

move init api calls, shuffle timing

b34622d

$body = $body doesn't work.

3e214c5

Move api specific constants to TBApi

c2a60ca

remove weird $body usage

fb0769f

Make sure tbui gets loaded at the right time.

66e3d0d

Not sure how this got back in there.

3837da9

Improve new modmail performance and reliability.

7dab1b5

eritbh self-requested a review October 26, 2020 20:39

creesch added 2 commits November 3, 2020 20:22

Merge branch 'master' into startup-performance

9714e82

Only listen to init events once

2230bad

eritbh reviewed Nov 17, 2020

View reviewed changes

creesch and others added 4 commits November 17, 2020 16:54

Better diff for geo ;)

bfcaf3a

Update extension/data/tbcore.js

4176e67

Co-authored-by: Geo <georgej1088@gmail.com>

Disable travis unit tests

e9469f0

Merge branch 'startup-performance' of https://github.com/toolbox-team…

f1d42b8

…/reddit-moderator-toolbox into startup-performance

eritbh added 2 commits July 13, 2022 14:55

Merge branch 'master' into startup-performance

2e6296c

Finish moving off TBCore errors and remove them

58c7db4

eritbh added the code quality label Jul 13, 2022

eritbh marked this pull request as ready for review July 13, 2022 19:10

eritbh added this to the v6.0 milestone Jul 31, 2022

creesch merged commit 3b883b6 into master Aug 18, 2022

creesch deleted the startup-performance branch August 18, 2022 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve startup performance #408

Improve startup performance #408

creesch commented Oct 24, 2020

eritbh left a comment

eritbh Nov 17, 2020

eritbh Nov 17, 2020

creesch Nov 17, 2020

eritbh Nov 17, 2020

creesch Nov 17, 2020

eritbh Nov 17, 2020

creesch Nov 17, 2020

eritbh Nov 17, 2020

creesch Nov 17, 2020

eritbh Nov 17, 2020

creesch Nov 17, 2020

eritbh Nov 17, 2020

creesch commented Nov 18, 2020

eritbh commented Jul 13, 2022

Improve startup performance #408

Improve startup performance #408

Conversation

creesch commented Oct 24, 2020

eritbh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

creesch commented Nov 18, 2020

eritbh commented Jul 13, 2022