Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Kubernetes Helm Chart #457

Merged
merged 58 commits into from
Mar 28, 2019
Merged

Provide Kubernetes Helm Chart #457

merged 58 commits into from
Mar 28, 2019

Conversation

cnadolny
Copy link
Contributor

@cnadolny cnadolny commented Mar 26, 2019 •
edited
Loading

Fixes #17 #143 #144 #459

Proposed Changes

  • Created Kubernetes Helm chart
  • Added liveness/readiness probes
  • Removed kubernetes-spec.yaml deployment file as it's replaced by the helm chart
  • Updated docs

cnadolny and others added 30 commits March 25, 2019 10:59
@cnadolny
Initial commit - added initial helm chart template
6070d42
@cnadolny
working changes
50ffaea
@cnadolny
more working changes
21c3163
@lee0c
Set secret var names & values for image in helm chart
16f2ac0
@cnadolny
edited configmap
82070cf
@cnadolny
removed ingress file
16b6c63
@cnadolny
forgot some vars
009b4eb
@lee0c
Define service values & var names
776f02a
@lee0c
Merge branch 'master' of github.com:cnadolny/promitor
861c030
@lee0c
Update helm chart values to use metrics config
0d63104
@lee0c
Add local values gitignore
b4b12fd
@lee0c
Can't have default SBQ metric as namespace is globally unique
fc8c552
@lee0c
helm chart fixes
91c2360
@cnadolny @lee0c
Helm chart progress
b603f98
@lee0c
Hellm
8d549b6
@lee0c
Merge branch 'master' of github.com:cnadolny/promitor
dd1e8b2
@lee0c
i can use git
efbd42c
@lee0c
Add additional environment variables
cd089b6
@cnadolny
Merge branch 'master' of https://github.com/tomkerkhove/promitor
254b216
@cnadolny
Merge branch 'master' of github.com:cnadolny/promitor
568bc65
@cnadolny
added readiness probe
d6de19e
@cnadolny
Merge branch 'master' of https://github.com/tomkerkhove/promitor
de8503c
@lee0c
Add scrape path env var
a222860
@lee0c
Merge branch 'master' of github.com:cnadolny/promitor
95126a4
@cnadolny
added liveness/readiness probe to kubernetes-spec
db8c4fc
@cnadolny
Merge branch 'master' of github.com:cnadolny/promitor
8e3cb17
@cnadolny
updated docs
4bd9e27
@cnadolny
removed kubernetes-spec
e5d40c2
@lee0c
Update values to align with metrics declaration
f4b1b1a
@lee0c
Merge branch 'master' of github.com:cnadolny/promitor
0f7d112
brusMX
brusMX reviewed Mar 27, 2019
View reviewed changes
Copy link
Contributor

@brusMX brusMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no PublicIPs, change it from LoadBalancer to ClusterIP

Also, please name the ports: https://kubernetes.io/docs/concepts/services-networking/service/#multi-port-services

@lee0c lee0c mentioned this pull request Mar 27, 2019
Closed
brusMX
brusMX reviewed Mar 27, 2019
View reviewed changes
Copy link
Contributor

@brusMX brusMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that if secrets or configmap is updated through --upgrade the helm re launches the pod with the proper info

@lee0c
Copy link
Contributor

lee0c commented Mar 27, 2019

Please make sure that if secrets or configmap is updated through --upgrade the helm re launches the pod with the proper info

Done, relevant doc: https://github.com/helm/helm/blob/master/docs/charts_tips_and_tricks.md#user-content-automatically-roll-deployments-when-configmaps-or-secrets-change

brusMX
brusMX approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@brusMX brusMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brusMX brusMX self-requested a review March 27, 2019 22:38
brusMX
brusMX approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@brusMX brusMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

@brusMX brusMX self-requested a review March 28, 2019 17:31
brusMX
brusMX approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@brusMX brusMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/shipit

@tomkerkhove tomkerkhove merged commit e8caf9f into tomkerkhove:master Mar 28, 2019
@tomkerkhove
Copy link
Owner

Merged, thanks guys!

@tomkerkhove tomkerkhove added this to the v1.0.0 milestone Apr 8, 2019
This was referenced Apr 8, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsturtevant jsturtevant jsturtevant left review comments

@lee0c lee0c lee0c left review comments

@brusMX brusMX brusMX approved these changes

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cnadolny @tomkerkhove @promitor-bot @lee0c @jsturtevant @brusMX