Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple resource groups in helm deployment #459

Closed
lee0c opened this issue Mar 26, 2019 · 4 comments
Closed

Support multiple resource groups in helm deployment #459

lee0c opened this issue Mar 26, 2019 · 4 comments
Labels
deployment All issues related to deploying Promitor helm All issues related to Helm kubernetes All issues related to Kubernetes
Milestone
v1.0.0

Comments

@lee0c
Copy link
Contributor

lee0c commented Mar 26, 2019

Follow up to #17, #294

Specification

Add resource group override for individual metrics to helm values/config map.
@tomkerkhove tomkerkhove added deployment All issues related to deploying Promitor kubernetes All issues related to Kubernetes helm All issues related to Helm labels Mar 26, 2019
@lee0c
Copy link
Contributor Author

lee0c commented Mar 27, 2019

Looking over @brusMX 's multi RG support, the current chart should actually support this by default. Will be fixed w/ #457

@cnadolny cnadolny mentioned this issue Mar 27, 2019
Merged
@tomkerkhove
Copy link
Owner

@lee0c Based on your comment I think we can close this, right?

@lee0c
Copy link
Contributor Author

lee0c commented Apr 1, 2019

Yes, the helm chart provides this support

@tomkerkhove
Copy link
Owner

🎉

@tomkerkhove tomkerkhove added this to the v1.0.0 milestone Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deployment All issues related to deploying Promitor helm All issues related to Helm kubernetes All issues related to Kubernetes
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@tomkerkhove @lee0c