-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding scraping interval to metricDefaults and metrics #456
Adding scraping interval to metricDefaults and metrics #456
Conversation
2c7662e
to
86b666e
Compare
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr456 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr456 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr456 |
1 similar comment
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr456 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr456 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr456 |
src/Promitor.Core.Scraping/Configuration/Model/MetricDefaults.cs
Outdated
Show resolved
Hide resolved
src/Promitor.Core.Scraping/Configuration/Model/Metrics/MetricDefinition.cs
Outdated
Show resolved
Hide resolved
src/Promitor.Core.Scraping/Configuration/Serialization/Core/MetricDefaultsDeserializer.cs
Show resolved
Hide resolved
src/Promitor.Core.Scraping/Configuration/Serialization/Core/MetricDeserializer.cs
Show resolved
Hide resolved
...lization/MetricsDeclaration/MetricsDeclarationWithAzureStorageQueueYamlSerializationTests.cs
Outdated
Show resolved
Hide resolved
d028667
to
9220830
Compare
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr456 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr456 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr456 |
9220830
to
87d7c19
Compare
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr456 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr456 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr456 |
…or most merge tools
…alize/deserialize matches the YAML definition
87d7c19
to
b8612b5
Compare
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr456 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-scraper-pr456 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env PROMITOR_AUTH_APPKEY='<azure-ad-app-key>' \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr456 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think my comments I will reserve my comments for the actual implementation
Partial fix for #258, #259
This adds the YAML configuration support for
metricDefaults.scraping.interval
and<metric>.scraping.interval
.As of this PR, however,
metricDefault
does not fill out the metric scraping interval if it is not supplied; this work must be done in the scraper and only makes sense after we have fully rid ourselves of theCronSchedule
Environment parameter. This will be done in a future PR.