Skip to content

Commit

Permalink
Adding **configuration** support for <metric>.scraping.interval
Browse files Browse the repository at this point in the history
Fixes #258
  • Loading branch information
brandonh-msft committed Mar 26, 2019
1 parent 48540e2 commit 2c7662e
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
namespace Promitor.Core.Scraping.Configuration.Model.Metrics
using System;

namespace Promitor.Core.Scraping.Configuration.Model.Metrics
{
public abstract class MetricDefinition
{
Expand All @@ -21,5 +23,10 @@ public abstract class MetricDefinition
/// Type of resource that is configured
/// </summary>
public abstract ResourceType ResourceType { get; }

/// <summary>
/// Gets or sets the scraping interval.
/// </summary>
public TimeSpan? ScrapingInterval { get; set; }
}
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using GuardNet;
using System;
using GuardNet;
using Microsoft.Extensions.Logging;
using Promitor.Core.Scraping.Configuration.Model.Metrics;
using YamlDotNet.RepresentationModel;
Expand Down Expand Up @@ -38,6 +39,17 @@ protected virtual TMetricDefinition DeserializeMetricDefinition<TMetricDefinitio
AzureMetricConfiguration = azureMetricConfiguration
};

if (metricNode.Children.ContainsKey(@"scraping"))
{
var scrapingNode = (YamlMappingNode)metricNode.Children[new YamlScalarNode(@"scraping")];
var scrapingIntervalNode = scrapingNode?.Children[new YamlScalarNode(@"interval")];

if (scrapingIntervalNode != null)
{
metricDefinition.ScrapingInterval = TimeSpan.Parse(scrapingIntervalNode.ToString());
}
}

return metricDefinition;
}
}
Expand Down

0 comments on commit 2c7662e

Please sign in to comment.