Fix wrong From impl for Resource
#1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Really not sure how this got past the tests.
davidpdrsn
force-pushed
the
fix-resource
branch
from
faa1703 to
aca73cf
Compare
3 tasks
jplatte
approved these changes
Nov 29, 2022
|
It wasn't wrong, just needlessly restrictive 😉 Note that this is technically a breaking change, as people could have relied on inference figuring out |
Yeah true but I think we should categorize it as acceptable breakage because it was hard/impossible to actually use previously. I ran into it with EmbarkStudios/server-framework#47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really not sure how this got past the tests.