Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to axum 0.6.0 #47

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Update to axum 0.6.0 #47

merged 4 commits into from
Nov 29, 2022

Conversation

davidpdrsn
Copy link
Contributor

@davidpdrsn davidpdrsn commented Nov 29, 2022 •
edited
Loading

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Requires tokio-rs/axum#1589 to be merged and shipped first.

We cannot use this in ark yet because we're still on tonic 0.7 there.

@davidpdrsn davidpdrsn mentioned this pull request Nov 29, 2022
Merged
@davidpdrsn davidpdrsn marked this pull request as ready for review November 29, 2022 10:01
MarcusGrass
MarcusGrass approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@MarcusGrass MarcusGrass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :shipit: 🔥 🚒
Weird that it didn't fail locally

@mergify mergify bot merged commit 5ef30c8 into main Nov 29, 2022
@mergify mergify bot deleted the update-axum branch November 29, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusGrass MarcusGrass MarcusGrass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidpdrsn @MarcusGrass