Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript: 4. Finalize GraphQL resolvers [MEGA PR] #229

Conversation

alukach
Copy link
Contributor

@alukach alukach commented Jun 27, 2024

This PR represents the complete conversion of src/api/**/*.

Additionally, it assumes a number of other currently-opened PRs have been merged:

Merging all of the above will make reviewing this PR much less onerous. Some additional changes in this PR exist that couldn't be committed directly to main via PR. For each of these changes, I made best effort to make targeted and described commits, allowing for per-commit review of changes if reasoning is not obvious.

Once this PR is approved, merge and then merge #206.

This PR is a part of #187.

@alukach alukach changed the title IN PROGRESS: Convert resolvers [COMPLETE] TypeScript: Convert resolvers [COMPLETE] Jun 27, 2024
@alukach alukach changed the title TypeScript: Convert resolvers [COMPLETE] TypeScript: Convert resolvers [MEGA PR] Jun 27, 2024
@alukach alukach marked this pull request as ready for review June 27, 2024 01:14
@alukach alukach changed the base branch from main to feature/typescript/graphql-resolvers June 27, 2024 01:15
@alukach alukach changed the title TypeScript: Convert resolvers [MEGA PR] TypeScript: Finalize resolvers [MEGA PR] Jun 27, 2024
@alukach alukach changed the title TypeScript: Finalize resolvers [MEGA PR] TypeScript: Finalize GraphQL resolvers [MEGA PR] Jun 27, 2024
@alukach alukach changed the title TypeScript: Finalize GraphQL resolvers [MEGA PR] TypeScript: 4. Finalize GraphQL resolvers [MEGA PR] Jun 27, 2024
@alukach alukach mentioned this pull request Jun 28, 2024
8 tasks
@nathanielrindlaub nathanielrindlaub merged commit 2fd4cae into feature/typescript/graphql-resolvers Jul 16, 2024
1 check passed
@nathanielrindlaub nathanielrindlaub deleted the feature/typescript/graphql-resolvers-with-merged-prs branch July 16, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants