TypeScript: Models(utils) #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alukach
force-pushed
the
feature/typescript/models-utils
branch
from
9bb78db
to
915ec33
Compare
alukach
changed the title
jue-henry
requested changes
Jul 5, 2024
nathanielrindlaub
approved these changes
Jul 16, 2024
| @@ -2,7 +2,7 @@ import GraphQLError, { InternalServerError } from '../../errors.js'; | |||
| import { WRITE_IMAGES_ROLES } from '../../auth/roles.js'; | |||
| import BatchError, { BatchErrorSchema } from '../schemas/BatchError.js'; | |||
| import retry from 'async-retry'; | |||
| import { BaseAuthedModel, GenericResponse, MethodParams, roleCheck } from './utils-model.js'; | |||
| import { BaseAuthedModel, GenericResponse, MethodParams, roleCheck } from './utils.js'; | |||
There was a problem hiding this comment.
I think all of these should now be imported from ./utils.ts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I'm changing
This PR converts
src/api/db/models/utils.jsto TypeScript.How I did it
mongodb-query-parserto get around the following issue:src/api/db/models/utils-model.tsintosrc/api/db/models/utils.tssrc/api/db/models/Camera.tsandsrc/api/db/models/ImageError.tsas they both had been mistakenly using@hasRolerather than@roleCheckpart of #187