fix: miscellaneous fixes on documentations #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuroitaki
commented
Jul 1, 2024
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| [mit-badge]: https://img.shields.io/badge/license-MIT-blue.svg | |||
| [apache-badge]: https://img.shields.io/github/license/saltstack/salt | |||
| [actions-badge]: https://github.com/tlsnotary/tlsn/actions/workflows/ci.yml/badge.svg | |||
| [actions-badge]: https://github.com/tlsnotary/tlsn/actions/workflows/ci.yml/badge.svg?branch=dev | |||
There was a problem hiding this comment.
the branch is needed, else any failed CI in any branch ll cause a failing status on the README.
yuroitaki
commented
Jul 1, 2024
yuroitaki
commented
Jul 1, 2024
| @@ -85,6 +85,6 @@ Feel free to try these extra challenges: | |||
|
|
|||
| ### Next steps | |||
|
|
|||
| Try out the [Discord example](../Discord/README.md) and notarize a Discord conversations. | |||
| Try out the [Discord example](../discord/README.md) and notarize a Discord conversations. | |||
There was a problem hiding this comment.
the uppercase is causing the link to be invalid on github website
yuroitaki
commented
Jul 4, 2024
CHANGELOG.md
Outdated
There was a problem hiding this comment.
removing this since it's not being used for now
yuroitaki
changed the title
yuroitaki
changed the title
themighty1
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.