Skip to content

Commit

Permalink
fix: miscellaneous fixes on documentations (#528)
Browse files Browse the repository at this point in the history
* fix: miscellaneous fixes on documentation, notary-server.

* Revert notary changes.

* Add warning when TLS is off.
  • Loading branch information
yuroitaki authored Jul 9, 2024
1 parent 3554db8 commit 44210c3
Show file tree
Hide file tree
Showing 8 changed files with 5 additions and 32 deletions.
7 changes: 0 additions & 7 deletions CHANGELOG.md

This file was deleted.

19 changes: 0 additions & 19 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,25 +16,6 @@ keywords.

Try to do one pull request per change.

### Updating the changelog

Update the changes you have made in
[CHANGELOG](CHANGELOG.md)
file under the **Unreleased** section.

Add the changes of your pull request to one of the following subsections,
depending on the types of changes defined by
[Keep a changelog](https://keepachangelog.com/en/1.0.0/):

- `Added` for new features.
- `Changed` for changes in existing functionality.
- `Deprecated` for soon-to-be removed features.
- `Removed` for now removed features.
- `Fixed` for any bug fixes.
- `Security` in case of vulnerabilities.

If the required subsection does not exist yet under **Unreleased**, create it!

## Style

### Capitalization and punctuation
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

[mit-badge]: https://img.shields.io/badge/license-MIT-blue.svg
[apache-badge]: https://img.shields.io/github/license/saltstack/salt
[actions-badge]: https://github.com/tlsnotary/tlsn/actions/workflows/ci.yml/badge.svg
[actions-badge]: https://github.com/tlsnotary/tlsn/actions/workflows/ci.yml/badge.svg?branch=dev
[actions-url]: https://github.com/tlsnotary/tlsn/actions?query=workflow%3Aci+branch%3Adev

[Website](https://tlsnotary.org) |
Expand Down
2 changes: 1 addition & 1 deletion notary/server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ The main objective of a notary server is to perform notarizations together with
### Features
#### Notarization Configuration
To perform a notarization, some parameters need to be configured by the prover and the notary server (more details in the [OpenAPI specification](./openapi.yaml)), i.e.
- maximum transcript size
- maximum data that can be sent and received
- unique session id

To streamline this process, a single HTTP endpoint (`/session`) is used by both TCP and WebSocket clients.
Expand Down
1 change: 0 additions & 1 deletion notary/server/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ components:
type: integer
required:
- "clientType"
- "maxTranscriptSize"
NotarizationSessionResponse:
type: object
properties:
Expand Down
2 changes: 1 addition & 1 deletion tlsn/examples/discord/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ You can find the `CHANNEL_ID` directly in the url:
`https://discord.com/channels/@me/{CHANNEL_ID)`

## Start the notary server
1. Edit the notary server [config file](../../../notary/server/config/config.yaml) to turn off TLS so that self-signed certificates can be avoided.
1. Edit the notary server [config file](../../../notary/server/config/config.yaml) to turn off TLS so that self-signed certificates can be avoided (⚠️ this is only for local development purposes — TLS must be used in production).
```yaml
tls:
enabled: false
Expand Down
2 changes: 1 addition & 1 deletion tlsn/examples/simple/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,6 @@ Feel free to try these extra challenges:

### Next steps

Try out the [Discord example](../Discord/README.md) and notarize a Discord conversations.
Try out the [Discord example](../discord/README.md) and notarize a Discord conversations.


2 changes: 1 addition & 1 deletion tlsn/examples/twitter/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Next, open the **Developer Tools**, go to the **Network** tab, and refresh the p
![Screenshot](twitter_dm_browser.png)

## Start the notary server
1. Edit the notary server [config file](../../../notary/server/config/config.yaml) to turn off TLS so that self-signed certificates can be avoided.
1. Edit the notary server [config file](../../../notary/server/config/config.yaml) to turn off TLS so that self-signed certificates can be avoided (⚠️ this is only for local development purposes — TLS must be used in production).
```yaml
tls:
enabled: false
Expand Down

0 comments on commit 44210c3

Please sign in to comment.