Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ops: promote 6.0.3 #3718

Merged
merged 119 commits into from
Jul 8, 2024
Merged

ops: promote 6.0.3 #3718

merged 119 commits into from
Jul 8, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Jul 8, 2024

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

latter-bolden and others added 30 commits June 21, 2024 12:56
We want to have some insights into how push notifications propagate to
client devices. But, client devices currently request notification
details through the scry endpoints, leaving us no way to write metadata
about the request into state. To support this, we make two changes:

First, we add new http endpoints under /apps/groups/~/notify, that
expose the same data that the current scry endpoints do; they support
both %activity-event and %hark-yarn shaped responses.

Second, we include a "first-req" timestamp alongside each notification
in state. Whenever an http request for a notification comes in, we set
that timestamp for that notification (if it wasn't already).

Additionally, instead of wiping all notification state periodically, we
now only wipe older notifications, leaving more-recent ones in place.
This way we should always keep around a relevant backlog of notification
details.
Adds a generator that displays some basic statistics about notifications
that exist in the notify agent's state, such as the amount that were
requested by the client, and the average amount of time it took for the
client to request them.

Note that this will be misleading when using clients that haven't yet
been updated to use the new endpoints, as without those, notifications
won't be marked as having been requested/served.

Example output:

Between ~2024.6.27 and ~2024.6.28,
Served 3 out of 4 notifications (75%).
Average time-to-request was ~s15.
Squashed commit of the following:

commit 5148d8c
Author: Dan Brewster <dnbrwstr@gmail.com>
Date:   Fri Jun 28 13:42:01 2024 -0400

    change item time color

commit 34aed7b
Author: Dan Brewster <dnbrwstr@gmail.com>
Date:   Fri Jun 28 13:33:20 2024 -0400

    list item tweaks
native: account for changes in thread unreads when using live post
patosullivan and others added 24 commits July 5, 2024 10:42
…t-list-focus

native: fetch pins on main list focus
nav-within-tab: make sure we send groups only stuff to the right place
@arthyn arthyn merged commit 27d8ca0 into staging Jul 8, 2024
1 check passed
@arthyn arthyn deleted the promote-6-0-3 branch July 8, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants