-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ops: promote 6.0.3 #3718
Merged
Merged
ops: promote 6.0.3 #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e to thread for reply notifs
We want to have some insights into how push notifications propagate to client devices. But, client devices currently request notification details through the scry endpoints, leaving us no way to write metadata about the request into state. To support this, we make two changes: First, we add new http endpoints under /apps/groups/~/notify, that expose the same data that the current scry endpoints do; they support both %activity-event and %hark-yarn shaped responses. Second, we include a "first-req" timestamp alongside each notification in state. Whenever an http request for a notification comes in, we set that timestamp for that notification (if it wasn't already). Additionally, instead of wiping all notification state periodically, we now only wipe older notifications, leaving more-recent ones in place. This way we should always keep around a relevant backlog of notification details.
Adds a generator that displays some basic statistics about notifications that exist in the notify agent's state, such as the amount that were requested by the client, and the average amount of time it took for the client to request them. Note that this will be misleading when using clients that haven't yet been updated to use the new endpoints, as without those, notifications won't be marked as having been requested/served. Example output: Between ~2024.6.27 and ~2024.6.28, Served 3 out of 4 notifications (75%). Average time-to-request was ~s15.
…nel as youd expect
native: unreads hotfix
native: enable iOS notifications
native: account for changes in thread unreads when using live post
native: fix reply references
…admin options for admins
… the group admin screens
activity: recursive unreads
native: channel polish
activity: dont mix maps and mops
…n up useGroupContext
…ager native: channel management screens
…t-list-focus native: fetch pins on main list focus
nav-within-tab: make sure we send groups only stuff to the right place
latter-bolden
approved these changes
Jul 8, 2024
patosullivan
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist