list item folder refactor #3697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latter-bolden
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Friday afternoon kind of refactor -- have been wanting to do this for a while, but it touches a lot. Our list items are pretty all over the place in how they're imported, where the main content is, etc.
This PR:
ListItemfolder where all ListItems live.ListItemshave been moved to standalone files that are named<X>ListItemand that export<X>ListItemas a named export.Not that this PR doesn't include any modifications to how code works, it just swaps things around. Will have a followup later that refactors/cleans up the files, but didn't want to obscure that work with the bigger move changes.