Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite Youdao service with Swift #774

Merged
merged 16 commits into from
Jan 5, 2025
Merged

refactor: rewrite Youdao service with Swift #774

merged 16 commits into from
Jan 5, 2025

Conversation

tisfeng
Copy link
Owner

@tisfeng tisfeng commented Jan 4, 2025

Fix #762 (comment)

Fix #769 , #775

Now we get Youdao secretKey by dynamic API.

Copy link

gitguardian bot commented Jan 4, 2025

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@tisfeng
Copy link
Owner Author

tisfeng commented Jan 5, 2025

Please review it quickly, this issue has caused thousands of crashes over the past few days, we need to solve it urgently.

image

Copy link
Collaborator

@Jerry23011 Jerry23011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crashes are fixed on my end compared to 2.10.2

LGTM.

@tisfeng tisfeng merged commit 5a096f7 into dev Jan 5, 2025
5 checks passed
@tisfeng tisfeng deleted the refactor-youdao branch January 5, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants