This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Payment Method id for confirm (Setup) Intent Results #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icateSetupIntent Related feature request for Android PaymentIntents: stripe/stripe-android#1445
|
@mindlapse -- They've already fixed my feature request: stripe/stripe-android#1445, this brings Android into line with iOS (re: the two iOS-only comments on PaymentIntent-related items). Do you want me to patch this PR to remove the iOS-only comments and bump our minimum stripe-android to >10.3.1? |
|
@fbartho do you fix this already ? I am also like this way, but I found the tipsi-stripe doesn't have this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
My backend team really would like it if I submitted the paymentMethodId to the backend when using confirmSetupIntent/confirmPaymentIntent (when using the create payment method optional parameters) -- to do that I have to change the response object for those APIs.
Types of changes
I discussed this in Discord, but people were offline at the time, so I figured I'd make a PR.
I wrote an attempt at the Android implementation, but I haven't verified if this fully works on Android. (This is our current convention).