Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Parity Request] PaymentIntent.getPaymentMethodId does not exist #1445

Closed
fbartho opened this issue Aug 28, 2019 · 1 comment · Fixed by #1446
Closed

[Parity Request] PaymentIntent.getPaymentMethodId does not exist #1445

fbartho opened this issue Aug 28, 2019 · 1 comment · Fixed by #1446
Assignees
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@fbartho
Copy link

fbartho commented Aug 28, 2019

Summary

I'm using Stripe via tipsi-stripe (React-Native, beta versions wrapping stripe-android & I'm contributing to getting tipsi-stripe SCA ready).

My backend team would love to use the confirm PaymentIntents flow just like we use confirm SetupIntents -- which is to say, the client collects the CreditCard with custom UI, then we create an Intent on the backend, then we submit the new PaymentMethod parameters as part of the call to confirm(Setup/Payment)Intent. Finally we submit the paymentMethodId to our backend to attach to the customer and invoice.

  1. SetupIntent objects on iOS/Android have a paymentMethodId/getPaymentMethodId() attribute/getter.]
  2. PaymentIntent objects on iOS have a paymentMethodId attribute
  3. PaymentIntent objects on Android do not have a getPaymentMethodId() getter

This would be particularly useful for when you're going through the confirm* flow, and you provide the parameters to create the PaymentMethod inline with that API call.

Code to reproduce

Documentation Pages:

  • SetupIntent: Android iOS
  • PaymentIntent: Android iOS
    Notice how PaymentIntent on Android-alone does not have a way to get the paymentMethod ID in this situation.

Android version

Any

Impacted devices

Not applicable

Installation method

tipsi-stripe uses maven/gradle?

SDK version

Latest / 10.3.1 / Main documentation site.

fbartho added a commit to tipsi/tipsi-stripe that referenced this issue Aug 29, 2019
…icateSetupIntent

Related feature request for Android PaymentIntents: stripe/stripe-android#1445
mshafrir-stripe added a commit that referenced this issue Aug 29, 2019
- Add missing field `payment_method`
- Add common getters to `StripeIntent`
- Use `long` instead of `Long` for timestamps
- Add comments to getters
- Mark certain methods as `@Deprecated`

Fixes #1445
@mshafrir-stripe
Copy link
Collaborator

@fbartho thanks for filing this. I've put up a fix.

@mshafrir-stripe mshafrir-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Aug 29, 2019
@mshafrir-stripe mshafrir-stripe self-assigned this Aug 29, 2019
mshafrir-stripe added a commit that referenced this issue Aug 29, 2019
- Add missing field `payment_method`
- Add common getters to `StripeIntent`
- Use `long` instead of `Long` for timestamps
- Add comments to getters
- Mark certain methods as `@Deprecated`

Fixes #1445
askd added a commit to spiral-modules/tipsi-stripe that referenced this issue Jan 23, 2020
* Stripe AppInfo added with stripe-android, react-native & android upgrade

AppInfo is needed so that Stripe can identify the transactions that are created through tipsi-stripe

Along with this, the compile and target SDK versions for android have been bumped to v28, stripe-android has been upgraded to 9.3.5, the minSdkVersion has increased to v19 (required).

Example app changes:
- Android compile and target SDK change from 26 -> 28
- Android min SDK change from 16 -> 19
- Android multiDexEnabled true
- Android support libraries upgraded to v28
- React native upgraded to 0.59.10
- React upgraded to 16.8.6
- android.useDeprecatedNdk=true was removed since it is no longer supported.
- android.enableAapt2=false was removed since it is now the default
- Gradle build tools upgraded to 3.4.1.  Gradle wrapper upgraded to v5.5.

* Adding .circleci

* Stripe AppInfo and library upgrades

- CircleCI config (for android)
- Android - Compile SDK version increased from 26 to 28
- Android - Target SDK version increased from 26 to 28
- Android - Min SDK version increased from 16 to 19
- Android - stripe-android increased from 8.1.0 to 9.3.5
- Android - Added Stripe AppInfo to requests

Example app:
- Updated react-native to 0.59.10 from 0.45.0
- Updated react to 16.8.6 from 16.0.x
- Upgraded gradle

Tests:
- Updated test suite to use webdriver 5.x from 4.7.1
- Update appium to 1.14

* stripe-ios AppInfo initial config

* `managedAccountCurrency` is no longer relevant according to the migration guide.

* typo-fixes

* Update Stripe CardForm options to support the "name"-only option in the requiredBillingAddressFields-option

* Dynamically list supported ApplePay networks on this device & write documentation

* Switch eslint-config & allow rules that are already existing patterns in the codebase

* Add missing docs pages, and reorganize the sidebars a little bit

* Add prettier to format the rendered-docs-html making diffing easier, and render the current docs

* Upgrade Example Project to Stripe 16 & Cocoapods changed something

* misc test fix

* React-Native 59 for the Example App for iOS

* ApplePay example tweaks now that it's running

* Got the testapp changes working!

* Prettier Javascript Formatting

* Extract Deprecated Methods to a separate file

* Adds Android confirmPayment, authenticatePayment, createPaymentMethod

Note: This commit breaks iOS - a subsequent commit is needed
Added confirmPayment, authenticatePayment, createPaymentMethod bindings for src/Stripe.js
Upgrade to stripe-android:10.1.1

* Adds Android confirmSetupIntent and authenticateSetup

 Note: This commit breaks iOS - a subsequent commit is needed

* Android changes for confirming a payment intent, with test page

- Confirmation of a payment intent resolves with { status, paymentIntentId }
- status is one of 'CANCELED', 'FAILED', 'SUCCEEDED', 'TIMEDOUT', or 'UNKNOWN'
- test page requires 'STRIPE_BACKEND' env to be defined, and it should contain a URL with a trailing slash pointing to a deployment of https://github.com/mindlapse/example-tipsi-stripe-backend

* Android changes for confirming a payment intent, with test page (cont..)

Wiring in the new example app PaymentIntentScreen

* Prettier configs in subfolders

* Prettier Formatting

* Adds SetupIntentScreen and stripe-android:10.2.1 (contains setupintent fix)

* PaymentIntent demo page updated to include manual entry with the card widget

* Add some jsDocs

* TPSCardField fixes

* iOS: Stub-in new methods, tweak certain bits of lifecycle

* API changes

- Dropped support for 'returnURL' for now (until there is demand for it to be introduced along with proper demo/tests)
- Added experimental Promise handling for authenticateSetup and authenticatePayment
- Allow a payment intent to be confirmed with just the clientSecret (without requiring a payment method to be provided client side)

* iOS: Implement Serializers / Parsers for marshalling parameters/results across the RN Bridge + JSDoc

* JSDoc: Missed a type

* iOS: error case robustness

* iOS: implement authenticatePaymentIntent / authenticateSetupIntent

* Prettier Formatting for PaymentIntent/SetupIntent Test Screens

* Tweak confirmPayment/confirmSetup to check & process 3DSecure Actions

* React 16.9 componentWillMount deleted compatibility

* Get Travis to install Xcode10.3 & Node >= 8.3

* oraclejdk8 is not supported on Travis's Xenial boxes

* Apply suggestions from code review

PRFeedback!

* Update npm to try to fix error

* Fix field focus infinite recursion in keyboardWillShow on > RN 45

Fixes tipsi#408

React-Native removed support for the react(Will|Did)MakeFirstResponder APIs in this commit: facebook/react-native@bc1ea54#diff-3e154f92c7ba4cb47e96785b9dadf3aa

* Fix incorrect test js syntax

* Fixup some issues with ci for ios

* Prettier formatting

* Adds test cards to demo page

Test cards can be found here:

https://stripe.com/docs/testing

* Adding manual confirmation support for Payment Intents

* Merge fixes, updated npm run configure to list rewrite envs

* Doc update - adds Objects > PaymentMethod

* Have new setup & payment intent methods return the status off of the intent itself

* example app: PaymentIntentScreen updates

* Added an extra test card (has no 3ds & always declines)

* Example app: automatic flow error handling update

* Additional test cards

* AddCardDialogFragment changes to support PaymentMethods

* Remove support for sourceId from confirmPayment

* tipsi-stripe iOS Native SDK version to 16.0.6

adrien.teulade-pod-point / timrc discussed this in Discord

* Remove Signatures that React-Native can't resolve at runtime

these are typedefs that revert to NSStrings at runtime, but that means that the name doesn't exist which then fails to pass their check here: https://github.com/facebook/react-native/blob/c20070f10458d48d6ac1eaac49e681e932bfb9fd/React/Base/RCTParserUtils.m#L119

* Example: Prettier (JS Formatting)

* Tighten up some types as per discussion

Discussion Thread: https://github.com/tipsi/tipsi-stripe/pull/515/files#r310823098

* Android: Ensure useStripeSDK is always set to true

* Adds returnURL to confirm calls and 'Intent' suffix to the Stripe.js interface

* Token fix

* Missed prettier-jsx formatting

* Robustness in CardParams parsing from tokens

* jsdoc cardparam.token

* iOS: API Naming Consistency

* iOS: Enable recommended modern iOS Warnings

* Fixup reasonable lint exceptions in the example app

* eslint-based fixes

* Example-app: API Naming Consistency with Native

* PaymentIntent requires_payment_method -> requires_paymentMethod based on iOS

* iOS, JS: fixup IntentStatus values to match Server Docs

* Disabling authenticateSetupIntent until we need it

* PaymentIntent guide - doc update

* Small fix to example app

* Roll 8.0.0-beta.1

* lint & prettier changes

* iOS Fixup `paymentRequestWithCardForm` for stripe-ios Breaking API Changes

* Add metadata support on Android

* Fix JSDocs around PaymentMethod customerId

* JSDoc the PaymentMethodCard Type -- especially Brand

* Misc consistency

* iOS: Don't assert if the paymentMethod is not provided in this helper (reused when a paymentMethodId might be provided)

* iOS: Use the official way to bridge CardBrands to Strings

* Android: Attempt to convert CardBrands instead of exposing the lowercased constant values

* Restored brand slugs for PaymentMethod card serialization

* Change CardBrand handling to expose API differences in Stripe Constant-values

* Card-based APIs expose brand as a Human Presentable Value -- eg "American Express"
* Newer, PaymentMethod:Card-based APIs expose brand as a brand-slug Identifier -- eg "amex"

* Add display utilities around card brands

* JSDoc the PaymentCardTextField Component

* Doc update, re: PaymentIntent API

* Roll 8.0.0-beta.2

* Fix iOS constant-key macro

* stripe-ios 16.0.7

* Removed support for token creation in stripe.paymentRequestWithCardForm

Only PaymentMethod creation is supported

* Removed support for token creation in stripe.paymentRequestWithCardForm

* PaymentCardTextField component, event bubbling issue

* Further Improve JSDocs

* Roll out 8.0.0-beta.3

* Updated changelog & appinfo

* iOS Stripe-AppInfo version to 8.x

* provide a status of unknown in the error state of serializing (Payment/Setup)IntentResults

This matches iOS

* iOS Changelog tweaks

* Make our post-link-ios script suggest stripe-ios 16.x

* Serialize `paymentMethodId` when resolving confirmSetupIntent/authenticateSetupIntent

Related feature request for Android PaymentIntents: stripe/stripe-android#1445

* stripe-android 10.4.0 & paymentMethodId consistency!

* Upgraded stripe-android to 10.4.0 and added paymentMethodId

* nil/null robustness (in case users pass null for this parameter)

* Parse & use the returnURL if provided for relevant APIs

* Quick-Document the returnURL property

* Better Connect Stripe Error Messages through to React-Native

* Roll out 8.0.0-beta.4

* Enable android pay in example app

* Docs: add saving card documentation

* Docs: build new version

* Finish up fixing the PaymentCardTextField Component iOS Lockup

Moots tipsi#508 tipsi#521

* iOS: Support using multiple Stripe accounts with 3DSecure

* Updated confirmSetupIntent error codes

* iOS: Android Error Consistency re: authenticationFailed

* Example app screen improvements

* Expose setStripeAccount to JS (Enable Stripe Connect accounts)

* Fix incorrect method access. Add usage and code to example app

* Roll out 8.0.0-beta.5

* iOS: Fix happy path for cards

* Roll out 8.0.0-beta.6

* iOS: Remove assert forcing paymentMethod/id to be passed to confirmPaymentIntent

Instead of forcing them to re-submit the same paymentMethod/paymentMethodId at the time of confirmPaymentIntent, the user can instead attach the paymentMethod/id on the backend before calling confirm

* Example app - added missing lines

* Fix for <STRIPE_ACCOUNT>

* Revert "Fix for <STRIPE_ACCOUNT>"

This reverts commit 7e61f1a.

* Revert 1a5a5cc

* Revert ee98528

* PropTypes: Allow omitting paymentMethod/paymentMethodId on confirmPaymentIntent

Fixes: tipsi#536

* iOS: Misc readability

* iOS: Treat `requires_capture` as a successful confirmPaymentIntent status

* Move the PaymentIntentStatusRequiresCapture check to the confirmPaymentIntent method

* confirmPaymentIntent: clean up wrong enum copy-paste error

* iOS: Default to useStripeSDK = true

* iOS: Clean up some unnecessary redundant returnURL parsing

* To align with iOS, the confirmPaymentIntent promise is rejected unless the payment intent ends up in `succeeded` or `requires_capture`

* If the resultingStatus of the PaymentIntent is either `succeeded`, or `requires_capture` then resolve the promise with `{ status: 'succeeded', ... }`
* If the resultingStatus of the PaymentIntent is either `canceled`, `requires_action`, or `requires_confirmation`, then consider the payment intent to be `cancelled` and reject the promise.
* Otherwise, consider the payment intent to be `failed` and reject the promise

* Roll out 8.0.0-beta.7

* Upgrade to latest stripe-android on the 10.4 branch

* Allow/Suggest stripe-ios @ 17.0.1 or later

* Android: Allow RequiresConfirmation to be a successful outcome

* Logic cleanup

* Roll out 8.0.0-beta.8

* Switch Statement Robustness -- stripe-ios 17.0.2 compatibility

* Prettier Formatting

* Migration doc

* Roll 8.0.0-beta.9

* [fix] AndroidX

Co-authored-by: Dave MacDonald <mindlapse@users.noreply.github.com>
Co-authored-by: Frederic Barthelemy <git@fbartho.com>
Co-authored-by: Kirill Pinchuk <cybergrind@gmail.com>
Co-authored-by: André Perdigão <andrepcg@gmail.com>
acmeyer added a commit to livelyhood/tipsi-stripe that referenced this issue Jun 12, 2020
* Stripe AppInfo added with stripe-android, react-native & android upgrade

AppInfo is needed so that Stripe can identify the transactions that are created through tipsi-stripe

Along with this, the compile and target SDK versions for android have been bumped to v28, stripe-android has been upgraded to 9.3.5, the minSdkVersion has increased to v19 (required).

Example app changes:
- Android compile and target SDK change from 26 -> 28
- Android min SDK change from 16 -> 19
- Android multiDexEnabled true
- Android support libraries upgraded to v28
- React native upgraded to 0.59.10
- React upgraded to 16.8.6
- android.useDeprecatedNdk=true was removed since it is no longer supported.
- android.enableAapt2=false was removed since it is now the default
- Gradle build tools upgraded to 3.4.1.  Gradle wrapper upgraded to v5.5.

* Adding .circleci

* Stripe AppInfo and library upgrades

- CircleCI config (for android)
- Android - Compile SDK version increased from 26 to 28
- Android - Target SDK version increased from 26 to 28
- Android - Min SDK version increased from 16 to 19
- Android - stripe-android increased from 8.1.0 to 9.3.5
- Android - Added Stripe AppInfo to requests

Example app:
- Updated react-native to 0.59.10 from 0.45.0
- Updated react to 16.8.6 from 16.0.x
- Upgraded gradle

Tests:
- Updated test suite to use webdriver 5.x from 4.7.1
- Update appium to 1.14

* stripe-ios AppInfo initial config

* `managedAccountCurrency` is no longer relevant according to the migration guide.

* typo-fixes

* Update Stripe CardForm options to support the "name"-only option in the requiredBillingAddressFields-option

* Dynamically list supported ApplePay networks on this device & write documentation

* Switch eslint-config & allow rules that are already existing patterns in the codebase

* Add missing docs pages, and reorganize the sidebars a little bit

* Add prettier to format the rendered-docs-html making diffing easier, and render the current docs

* Upgrade Example Project to Stripe 16 & Cocoapods changed something

* misc test fix

* React-Native 59 for the Example App for iOS

* ApplePay example tweaks now that it's running

* Got the testapp changes working!

* Prettier Javascript Formatting

* Extract Deprecated Methods to a separate file

* Adds Android confirmPayment, authenticatePayment, createPaymentMethod

Note: This commit breaks iOS - a subsequent commit is needed
Added confirmPayment, authenticatePayment, createPaymentMethod bindings for src/Stripe.js
Upgrade to stripe-android:10.1.1

* Adds Android confirmSetupIntent and authenticateSetup

 Note: This commit breaks iOS - a subsequent commit is needed

* Android changes for confirming a payment intent, with test page

- Confirmation of a payment intent resolves with { status, paymentIntentId }
- status is one of 'CANCELED', 'FAILED', 'SUCCEEDED', 'TIMEDOUT', or 'UNKNOWN'
- test page requires 'STRIPE_BACKEND' env to be defined, and it should contain a URL with a trailing slash pointing to a deployment of https://github.com/mindlapse/example-tipsi-stripe-backend

* Android changes for confirming a payment intent, with test page (cont..)

Wiring in the new example app PaymentIntentScreen

* Prettier configs in subfolders

* Prettier Formatting

* Adds SetupIntentScreen and stripe-android:10.2.1 (contains setupintent fix)

* PaymentIntent demo page updated to include manual entry with the card widget

* Add some jsDocs

* TPSCardField fixes

* iOS: Stub-in new methods, tweak certain bits of lifecycle

* API changes

- Dropped support for 'returnURL' for now (until there is demand for it to be introduced along with proper demo/tests)
- Added experimental Promise handling for authenticateSetup and authenticatePayment
- Allow a payment intent to be confirmed with just the clientSecret (without requiring a payment method to be provided client side)

* iOS: Implement Serializers / Parsers for marshalling parameters/results across the RN Bridge + JSDoc

* JSDoc: Missed a type

* iOS: error case robustness

* iOS: implement authenticatePaymentIntent / authenticateSetupIntent

* Prettier Formatting for PaymentIntent/SetupIntent Test Screens

* Tweak confirmPayment/confirmSetup to check & process 3DSecure Actions

* React 16.9 componentWillMount deleted compatibility

* Get Travis to install Xcode10.3 & Node >= 8.3

* oraclejdk8 is not supported on Travis's Xenial boxes

* Apply suggestions from code review

PRFeedback!

* Update npm to try to fix error

* Fix field focus infinite recursion in keyboardWillShow on > RN 45

Fixes tipsi#408

React-Native removed support for the react(Will|Did)MakeFirstResponder APIs in this commit: facebook/react-native@bc1ea54#diff-3e154f92c7ba4cb47e96785b9dadf3aa

* Fix incorrect test js syntax

* Fixup some issues with ci for ios

* Prettier formatting

* Adds test cards to demo page

Test cards can be found here:

https://stripe.com/docs/testing

* Adding manual confirmation support for Payment Intents

* Merge fixes, updated npm run configure to list rewrite envs

* Doc update - adds Objects > PaymentMethod

* Have new setup & payment intent methods return the status off of the intent itself

* example app: PaymentIntentScreen updates

* Added an extra test card (has no 3ds & always declines)

* Example app: automatic flow error handling update

* Additional test cards

* AddCardDialogFragment changes to support PaymentMethods

* Remove support for sourceId from confirmPayment

* tipsi-stripe iOS Native SDK version to 16.0.6

adrien.teulade-pod-point / timrc discussed this in Discord

* Remove Signatures that React-Native can't resolve at runtime

these are typedefs that revert to NSStrings at runtime, but that means that the name doesn't exist which then fails to pass their check here: https://github.com/facebook/react-native/blob/c20070f10458d48d6ac1eaac49e681e932bfb9fd/React/Base/RCTParserUtils.m#L119

* Example: Prettier (JS Formatting)

* Tighten up some types as per discussion

Discussion Thread: https://github.com/tipsi/tipsi-stripe/pull/515/files#r310823098

* Android: Ensure useStripeSDK is always set to true

* Adds returnURL to confirm calls and 'Intent' suffix to the Stripe.js interface

* Token fix

* Missed prettier-jsx formatting

* Robustness in CardParams parsing from tokens

* jsdoc cardparam.token

* iOS: API Naming Consistency

* iOS: Enable recommended modern iOS Warnings

* Fixup reasonable lint exceptions in the example app

* eslint-based fixes

* Example-app: API Naming Consistency with Native

* PaymentIntent requires_payment_method -> requires_paymentMethod based on iOS

* iOS, JS: fixup IntentStatus values to match Server Docs

* Disabling authenticateSetupIntent until we need it

* PaymentIntent guide - doc update

* Small fix to example app

* Roll 8.0.0-beta.1

* lint & prettier changes

* iOS Fixup `paymentRequestWithCardForm` for stripe-ios Breaking API Changes

* Add metadata support on Android

* Fix JSDocs around PaymentMethod customerId

* JSDoc the PaymentMethodCard Type -- especially Brand

* Misc consistency

* iOS: Don't assert if the paymentMethod is not provided in this helper (reused when a paymentMethodId might be provided)

* iOS: Use the official way to bridge CardBrands to Strings

* Android: Attempt to convert CardBrands instead of exposing the lowercased constant values

* Restored brand slugs for PaymentMethod card serialization

* Change CardBrand handling to expose API differences in Stripe Constant-values

* Card-based APIs expose brand as a Human Presentable Value -- eg "American Express"
* Newer, PaymentMethod:Card-based APIs expose brand as a brand-slug Identifier -- eg "amex"

* Add display utilities around card brands

* JSDoc the PaymentCardTextField Component

* Doc update, re: PaymentIntent API

* Roll 8.0.0-beta.2

* Fix iOS constant-key macro

* stripe-ios 16.0.7

* Removed support for token creation in stripe.paymentRequestWithCardForm

Only PaymentMethod creation is supported

* Removed support for token creation in stripe.paymentRequestWithCardForm

* PaymentCardTextField component, event bubbling issue

* Further Improve JSDocs

* Roll out 8.0.0-beta.3

* Updated changelog & appinfo

* iOS Stripe-AppInfo version to 8.x

* provide a status of unknown in the error state of serializing (Payment/Setup)IntentResults

This matches iOS

* iOS Changelog tweaks

* Make our post-link-ios script suggest stripe-ios 16.x

* Serialize `paymentMethodId` when resolving confirmSetupIntent/authenticateSetupIntent

Related feature request for Android PaymentIntents: stripe/stripe-android#1445

* stripe-android 10.4.0 & paymentMethodId consistency!

* Upgraded stripe-android to 10.4.0 and added paymentMethodId

* nil/null robustness (in case users pass null for this parameter)

* Parse & use the returnURL if provided for relevant APIs

* Quick-Document the returnURL property

* Better Connect Stripe Error Messages through to React-Native

* Roll out 8.0.0-beta.4

* Enable android pay in example app

* Docs: add saving card documentation

* Docs: build new version

* Finish up fixing the PaymentCardTextField Component iOS Lockup

Moots tipsi#508 tipsi#521

* iOS: Support using multiple Stripe accounts with 3DSecure

* Updated confirmSetupIntent error codes

* iOS: Android Error Consistency re: authenticationFailed

* Example app screen improvements

* Expose setStripeAccount to JS (Enable Stripe Connect accounts)

* Fix incorrect method access. Add usage and code to example app

* Roll out 8.0.0-beta.5

* iOS: Fix happy path for cards

* Roll out 8.0.0-beta.6

* iOS: Remove assert forcing paymentMethod/id to be passed to confirmPaymentIntent

Instead of forcing them to re-submit the same paymentMethod/paymentMethodId at the time of confirmPaymentIntent, the user can instead attach the paymentMethod/id on the backend before calling confirm

* Example app - added missing lines

* Fix for <STRIPE_ACCOUNT>

* Revert "Fix for <STRIPE_ACCOUNT>"

This reverts commit 7e61f1a.

* Revert 1a5a5cc

* Revert ee98528

* PropTypes: Allow omitting paymentMethod/paymentMethodId on confirmPaymentIntent

Fixes: tipsi#536

* iOS: Misc readability

* iOS: Treat `requires_capture` as a successful confirmPaymentIntent status

* Move the PaymentIntentStatusRequiresCapture check to the confirmPaymentIntent method

* confirmPaymentIntent: clean up wrong enum copy-paste error

* iOS: Default to useStripeSDK = true

* iOS: Clean up some unnecessary redundant returnURL parsing

* To align with iOS, the confirmPaymentIntent promise is rejected unless the payment intent ends up in `succeeded` or `requires_capture`

* If the resultingStatus of the PaymentIntent is either `succeeded`, or `requires_capture` then resolve the promise with `{ status: 'succeeded', ... }`
* If the resultingStatus of the PaymentIntent is either `canceled`, `requires_action`, or `requires_confirmation`, then consider the payment intent to be `cancelled` and reject the promise.
* Otherwise, consider the payment intent to be `failed` and reject the promise

* Roll out 8.0.0-beta.7

* Upgrade to latest stripe-android on the 10.4 branch

* Allow/Suggest stripe-ios @ 17.0.1 or later

* Android: Allow RequiresConfirmation to be a successful outcome

* Logic cleanup

* Roll out 8.0.0-beta.8

* Switch Statement Robustness -- stripe-ios 17.0.2 compatibility

* Prettier Formatting

* Add setStripeAccount support.

Adds Stripe Connect Support.
new JS method `setStripeAccount` which can be an account id or null.

* Migration doc

* Upgrade tipsi-android to 1.4.6

See: stripe/stripe-android#1654

* Roll 8.0.0-beta.9

* Fix extracting billingDetails

* Fixed compilation error for 8.0.0.beta9 due to fpx issue

* Mark an unsupported entry with a comment

* Fix build on xcode 11.4

See stripe/stripe-ios#1526

* Update npmignore

* Update for AndroidX (#2)

* Saving before trying android studio migrate

* AndroidX conversion tweaks

* AndroidX conversion tweaks

Co-authored-by: Tomas Maly <tmaly1980@gmail.com>

Co-authored-by: Dave MacDonald <mindlapse@gmail.com>
Co-authored-by: Frederic Barthelemy <git@fbartho.com>
Co-authored-by: Kirill Pinchuk <cybergrind@gmail.com>
Co-authored-by: Dave MacDonald <mindlapse@users.noreply.github.com>
Co-authored-by: André Perdigão <andrepcg@gmail.com>
Co-authored-by: Bram Whillock <bramski@gmail.com>
Co-authored-by: Igor Kozlovsky <igor.lemon.kozlovsky@gmail.com>
Co-authored-by: Max Hung <info@maxhung.co.nz>
Co-authored-by: Torres Yang <yangguanhua@gmail.com>
Co-authored-by: Tomas Maly <tmaly1980@gmail.com>
renabriseno68 added a commit to renabriseno68/android-flutter-tipsi-stripe that referenced this issue Sep 13, 2022
…icateSetupIntent

Related feature request for Android PaymentIntents: stripe/stripe-android#1445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants