Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Management buttons should require collaborator access #20

Closed
timwis opened this issue Mar 18, 2016 · 3 comments
Closed

Management buttons should require collaborator access #20

timwis opened this issue Mar 18, 2016 · 3 comments
Milestone
v1.0

Comments

@timwis
Copy link
Owner

timwis commented Mar 18, 2016

Edit/add/delete/admin/setup buttons/pages

  • Anonymous users: buttons should say "Suggest Changes" etc. and prompt them to login
  • Logged-in users (non-collaborators): buttons should say "Suggest Changes" etc. and submit a pull request
  • Logged-in Collaborators: buttons should say "Edit" etc. and make commits
timwis added a commit that referenced this issue Mar 22, 2016
@timwis
check if collaborator before showing edit button. closes #16 closes #20
47dc258
@timwis
Copy link
Owner Author

timwis commented Mar 22, 2016

This and #16 are complete pending github-tools/github#304 being merged

@JJediny
Copy link
Contributor

JJediny commented Mar 24, 2016

Might it make sense to consider a hybrid of liquid conditional logic coupled with the github.js to reduce the number of calls being made to github api (which could throttle over there allowed thresholds)?

@JJediny
Copy link
Contributor

JJediny commented Mar 24, 2016

Disregard, as using liquid to hide the edit visibility would only work if essentially 2 views of the entire site we're to compiled one for view-only the other with edit. Seems appropriate to manage user state with JS and have that alter view/edit switching

@timwis timwis mentioned this issue Mar 28, 2016
Closed
@timwis timwis changed the title Editing should be locked down to users who have write access to repo Management buttons should reflect user access Mar 28, 2016
This was referenced Mar 30, 2016
Closed
Merged
@timwis timwis closed this as completed Apr 4, 2016
@timwis timwis reopened this Apr 4, 2016
@timwis timwis changed the title Management buttons should reflect user access Management buttons should require collaborator access Apr 4, 2016
@timwis timwis modified the milestone: v1.0 Apr 4, 2016
@timwis timwis closed this as completed in #67 Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
2 participants
@timwis @JJediny