-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sudo proton install
to install to /usr/local/bin on Mac instead of the locked /usr/bin
#651
Conversation
/usr/bin is locked on Mac. Change it to /usr/local/bin. This should also work on Linux
a74ecd1
to
594ae5b
Compare
1. increase open files limit. ClickHouse/ClickHouse#41345 2. use stringview instead char* 3. maybe better for throw exception 4. try take a hardlink first before copy. ClickHouse/ClickHouse#48578
This comment was marked as resolved.
This comment was marked as resolved.
I hide the previous comment, seems the problem is my homebrew or old proton-server pollution. after clean the folder, my local is work and valid. but this is really dangerous, because the default proton search the homebrew first.
|
Thanks for new commits, @yokofly Yes, it will mess up things if the user homebrew install first then proton install again. I think it's fair to say
|
do u mean make the homebrew same behavior with proton install? edit: understand,the rest part shall be homebrew, this pr is enough for local install. |
Feel free to merge if you think it's ready. Let me list 3 cases
This PR only addresses 1. You can keep working in https://github.com/timeplus-io/homebrew-timeplus and https://github.com/timeplus-io/install.timeplus.com |
sudo proton install
to install to /usr/local/bin instead of the locked /usr/binsudo proton install
to install to /usr/local/bin on Mac instead of the locked /usr/bin
Since @yokofly said "this pr is enough for local install." So I will merge it and put in 1.5.5 |
/usr/bin is locked on Mac. Change it to /usr/local/bin. This should also work on Linux
PR checklist:
proton: starts/ends
for new code in existing community code base ?Please write user-readable short description of the changes: