Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly optimize Install #48578

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

The installation script will create a hard link instead of copying if it is possible.

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-improvement Pull request with some product improvements label Apr 10, 2023
@evillique evillique self-assigned this Apr 10, 2023
@alexey-milovidov alexey-milovidov merged commit 51688bb into master Apr 10, 2023
@alexey-milovidov alexey-milovidov deleted the slightly-optimize-install branch April 10, 2023 18:17
yokofly added a commit to timeplus-io/proton that referenced this pull request Apr 10, 2024
1. increase open files limit. ClickHouse/ClickHouse#41345
2. use stringview instead char*
3. maybe better for throw exception
4. try take a hardlink first before copy. ClickHouse/ClickHouse#48578
jovezhong added a commit to timeplus-io/proton that referenced this pull request Apr 10, 2024
…the locked /usr/bin (#651)

* Update Install.cpp

/usr/bin is locked on Mac. Change it to /usr/local/bin. This should also work on Linux

* 2 more usr/bin to usr/local/bin

* minor clean:
1. increase open files limit. ClickHouse/ClickHouse#41345
2. use stringview instead char*
3. maybe better for throw exception
4. try take a hardlink first before copy. ClickHouse/ClickHouse#48578

* conditional compile

* fix the incorrect usage, the default is usr/bin otherwise only tag for macOS

---------

Co-authored-by: yoko <haohang.shi@timeplus.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants