assets: embedded asset server #5622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksieger
force-pushed
the
nicksieger/embedded-assets
branch
from
8fd0236 to
23286bf
Compare
Remove precompiled server.
This was
linked to
issues
Mar 23, 2022
nicks
reviewed
Mar 23, 2022
pkg/assets/embedded.go
Outdated
| http.Handler | ||
| } | ||
|
|
||
| func NewEmbeddedServer() (Server, error) { |
There was a problem hiding this comment.
i think the more idiomatic API is something like:
GetEmbeddedServer() (Server, bool)
since "the server doesn't exist" isn't something that you're treating as an error. here's an example of an API that does this: https://pkg.go.dev/os#LookupEnv
nicksieger
force-pushed
the
nicksieger/embedded-assets
branch
from
8c30625 to
d0588e1
Compare
nicksieger
force-pushed
the
nicksieger/embedded-assets
branch
from
d0588e1 to
ef64b94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During release builds, copy js assets to pkg/assets/build for embedding in the Tilt executable using go:embed. When in
--web-mode=prod, prefer embedded asset server to prod asset server if embedded assets are available, identified by index.html being present.Also,
PrecompiledWebModeis replaced by this embedded server as well, since both run from the result ofmake build-js.