Fix <input disabled>

[linstula]

Demo showing the same is parsed as disabled: true in normal HTML: http://jsbin.com/magegorene/1/

paired with @rwjblue on this.

[mixonic]

@rwjblue is going to take a quick look here, I'll followup regardless this week.

[linstula]

As discussed between @rwjblue and @mixonic we need to change packages/htmlbars-compiler/lib/fragment-javascript-compiler.js#L64 to call setAttribute instead of setProperty to fix this issue. Looks like the changes from #235 made this somewhat more complicated.

[rwjblue]

emberjs/ember.js#10169 is due to the same underlying issue.

[oneeman]

I'd be happy to give this a shot, but I'm not really clear on when setAttribute should be used vs when setProperty should. So, just to make sure, Is it a matter of using setAttribute or setAttributeNS everywhere in the build() method? Or are there also issues when it comes to hydration/morphs?

[oneeman]

ok, this works, go ahead and add it please:

FragmentJavaScriptCompiler.prototype.setAttribute = function(name, value, namespace) {
  var el = 'el'+this.depth;
  if (namespace) {
    this.source.push(this.indent+'  dom.setAttributeNS('+el+','+string(namespace)+','+string(name)+','+string(value)+
                     ');\n');
  } else {
    this.source.push(this.indent+'  dom.setAttribute('+el+','+string(name)+','+string(value)+');\n');
  }
};

There's a bit of duplication between the then and else clauses, but trying to eliminate would probably only make it more complicated.

[linstula]

@oneeman thanks for putting in the work for this. Should be good to go.

[oneeman]

Thank you! The test failures are from before on IE, so I'll go ahead and merge.

[zeppelin]

👍