Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes without value disappear #10169

Closed
zeppelin opened this issue Jan 8, 2015 · 7 comments
Closed

Attributes without value disappear #10169

zeppelin opened this issue Jan 8, 2015 · 7 comments
Assignees
Labels

Comments

@zeppelin
Copy link
Contributor

zeppelin commented Jan 8, 2015

With ember-canary

<form novalidate></form>

is rendered as:

<form></form>

1.9.1 renders the element correctly

JSBin: http://emberjs.jsbin.com/diveni/1/edit?html,output

@rwjblue
Copy link
Member

rwjblue commented Jan 8, 2015

I submitted a failing test to HTMLBars for this yesterday. There is a plan of attack, but needs someone to pick it up.

tildeio/htmlbars#239

@rwjblue
Copy link
Member

rwjblue commented Jan 12, 2015

This should be fixed on master and in beta (both are using v0.8.1 of htmlbars).

@rwjblue rwjblue closed this as completed Jan 12, 2015
@wagenet
Copy link
Member

wagenet commented Jan 12, 2015

I'm still seeing issues with this. I'm on ember-cli 0.1.5 with ember 1.10.beta.4 with ember-cli-htmlbars 0.6.0.

@wagenet wagenet reopened this Jan 12, 2015
@wagenet
Copy link
Member

wagenet commented Jan 12, 2015

@rwjblue
Copy link
Member

rwjblue commented Jan 12, 2015

@wagenet - Yours is not the same as the originally reported issue. This issue is with plain HTML in a template <form novalidate></form>. You are using attributeBindings which is quite different.

A screenshot from the original JSBin (demonstrating that this is working properly now):

screenshot

@rwjblue
Copy link
Member

rwjblue commented Jan 12, 2015

@wagenet - Closing this in favor of #10202 (which is specifically for the issue in your JSBin).

@rwjblue rwjblue closed this as completed Jan 12, 2015
@wagenet
Copy link
Member

wagenet commented Jan 12, 2015

@rwjblue you're right. My mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants